Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1114303002: Abort master management if the current hostname doesn't match the master's. (Closed)

Created:
5 years, 7 months ago by ghost stip (do not use)
Modified:
5 years, 7 months ago
Reviewers:
agable
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Abort master management if the current hostname doesn't match the master's. BUG=479059 Committed: https://chromium.googlesource.com/infra/infra/+/11f1b8c698245fe9609a937ea7a0129205bde222

Patch Set 1 #

Patch Set 2 : Rebase onto latest master. #

Total comments: 2

Patch Set 3 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M infra/libs/buildbot/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M infra/libs/buildbot/master.py View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/tools/master_manager/__main__.py View 1 2 4 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ghost stip (do not use)
ptal
5 years, 7 months ago (2015-05-01 07:51:00 UTC) #2
agable
LGTM % typo https://codereview.chromium.org/1114303002/diff/20001/infra/tools/master_manager/__main__.py File infra/tools/master_manager/__main__.py (right): https://codereview.chromium.org/1114303002/diff/20001/infra/tools/master_manager/__main__.py#newcode44 infra/tools/master_manager/__main__.py:44: help='override local hostname (currently %defaults)') %defaults? ...
5 years, 7 months ago (2015-05-05 18:58:29 UTC) #3
ghost stip (do not use)
https://chromiumcodereview.appspot.com/1114303002/diff/20001/infra/tools/master_manager/__main__.py File infra/tools/master_manager/__main__.py (right): https://chromiumcodereview.appspot.com/1114303002/diff/20001/infra/tools/master_manager/__main__.py#newcode44 infra/tools/master_manager/__main__.py:44: help='override local hostname (currently %defaults)') On 2015/05/05 18:58:29, agable ...
5 years, 7 months ago (2015-05-05 23:41:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114303002/40001
5 years, 7 months ago (2015-05-05 23:42:12 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 23:46:16 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/11f1b8c698245fe9609a937ea7a01...

Powered by Google App Engine
This is Rietveld 408576698