Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Unified Diff: chrome/browser/chrome_browser_application_mac.mm

Issue 11140040: [Mac] Additional crash logging for -sendEvent: crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_application_mac.mm
diff --git a/chrome/browser/chrome_browser_application_mac.mm b/chrome/browser/chrome_browser_application_mac.mm
index 93ea7b0d87902bcda35948c84f836e4219e22b65..2ce5ea8230e98f5d3881f7474a3ea64efcfc010d 100644
--- a/chrome/browser/chrome_browser_application_mac.mm
+++ b/chrome/browser/chrome_browser_application_mac.mm
@@ -431,6 +431,12 @@ void SwizzleInit() {
}
- (void)sendEvent:(NSEvent*)event {
+ // TODO(shess): Squirrel away some info to direct debugging.
+ // Current hypothesis is that it's a keyboard accelerator.
+ // http://crbug.com/154483
+ static NSString* const kSendEventKey = @"sendevent";
+ base::mac::ScopedCrashKey key(kSendEventKey, [event description]);
+
base::mac::ScopedSendingEvent sendingEventScoper;
for (id<CrApplicationEventHookProtocol> handler in eventHooks_.get()) {
[handler hookForEvent:event];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698