Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 11140015: Cleanup: Rename to base::SysInfo::CPUArchitecture() to OperatingSystemArchitecture(). (Closed)

Created:
8 years, 2 months ago by Lei Zhang
Modified:
8 years, 2 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, MAD, mihaip-chromium-reviews_chromium.org, simonmorris+watch_chromium.org, jar (doing other things), hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, erikwright+watch_chromium.org, Ilya Sherman, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Rename to base::SysInfo::CPUArchitecture() to OperatingSystemArchitecture(). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162041

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M base/sys_info.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/sys_info_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/device_management_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/webdriver/webdriver_dispatch.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/server_log_entry.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
mark: PTAL at base/ and chrome/ garykac: remoting/
8 years, 2 months ago (2012-10-15 21:46:38 UTC) #1
Mark Mentovai
LGTM
8 years, 2 months ago (2012-10-15 22:06:43 UTC) #2
Sergey Ulanov
remoting/ - LGTM
8 years, 2 months ago (2012-10-15 22:28:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11140015/1009
8 years, 2 months ago (2012-10-15 22:36:54 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 01:58:24 UTC) #5
Change committed as 162041

Powered by Google App Engine
This is Rietveld 408576698