chrome/browser/metrics/metrics_log.cc - Issue 11140015: Cleanup: Rename to base::SysInfo::CPUArchitecture() to OperatingSystemArchitecture().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 11140015: Cleanup: Rename to base::SysInfo::CPUArchitecture() to OperatingSystemArchitecture(). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc ('k') | chrome/browser/policy/device_management_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_log.cc

===================================================================

--- chrome/browser/metrics/metrics_log.cc (revision 161772)

+++ chrome/browser/metrics/metrics_log.cc (working copy)

@@ -670,7 +670,7 @@

// Write the XML version.

// We'll write the protobuf version in RecordEnvironmentProto().

OPEN_ELEMENT_FOR_SCOPE("cpu");

- WriteAttribute("arch", base::SysInfo::CPUArchitecture());

+ WriteAttribute("arch", base::SysInfo::OperatingSystemArchitecture());

}

{

@@ -765,7 +765,7 @@

content::GetContentClient()->browser()->GetApplicationLocale());

SystemProfileProto::Hardware* hardware = system_profile->mutable_hardware();

- hardware->set_cpu_architecture(base::SysInfo::CPUArchitecture());

+ hardware->set_cpu_architecture(base::SysInfo::OperatingSystemArchitecture());

hardware->set_system_ram_mb(base::SysInfo::AmountOfPhysicalMemoryMB());

#if defined(OS_WIN)

hardware->set_dll_base(reinterpret_cast<uint64>(&__ImageBase));

@@ -866,7 +866,7 @@

i != profile_metrics.end_keys(); ++i) {

const Value* value;

if (profile_metrics.GetWithoutPathExpansion(*i, &value)) {

- DCHECK(*i != "id");

+ DCHECK_NE(*i, "id");

switch (value->GetType()) {

case Value::TYPE_STRING: {

std::string string_value;