Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3350)

Unified Diff: build/android/envsetup_functions.sh

Issue 11137023: Remove redundant command line option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more removal Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/envsetup.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/envsetup_functions.sh
diff --git a/build/android/envsetup_functions.sh b/build/android/envsetup_functions.sh
index da8a4ee57a3d4da47f250bb92b4da3f2bc061dfd..298fb97e30db329a760b615968f69aed0c191324 100755
--- a/build/android/envsetup_functions.sh
+++ b/build/android/envsetup_functions.sh
@@ -165,11 +165,10 @@ common_gyp_vars() {
# environment ANDROID_NDK_ROOT must be set to Android NDK's root path. The
# ANDROID_SDK_ROOT only needs to be set to override the default SDK which is in
# the tree under $ROOT/src/third_party/android_tools/sdk.
-# TODO(navabi): Add NDK to $ROOT/src/third_party/android_tools/ndk.
# To build Chromium for Android with NDK/SDK follow the steps below:
# > export ANDROID_NDK_ROOT=<android ndk root>
# > export ANDROID_SDK_ROOT=<android sdk root> # to override the default sdk
-# > . build/android/envsetup.sh --sdk
+# > . build/android/envsetup.sh
# > make
################################################################################
sdk_build_init() {
@@ -188,7 +187,6 @@ sdk_build_init() {
export ANDROID_SDK_ROOT="${CHROME_SRC}/third_party/android_tools/sdk/"
fi
- # Makes sure ANDROID_BUILD_TOP is unset if build has option --sdk
unset ANDROID_BUILD_TOP
# Set default target.
@@ -236,59 +234,6 @@ sdk_build_init() {
}
################################################################################
-# Initializes environment variables for build with android source. This expects
-# android environment to be set up along with lunch. To build:
-# > . build/envsetup.sh
-# > lunch <lunch-type>
-# > . build/android/envsetup.sh
-# > make
-#############################################################################
-non_sdk_build_init() {
- # We export "TOP" here so that "mmm" can be run to build Java code without
- # having to cd to $ANDROID_BUILD_TOP.
- export TOP="$ANDROID_BUILD_TOP"
-
- # Set "ANDROID_NDK_ROOT" as checked-in version, if it was not set.
- if [[ "${ANDROID_NDK_ROOT}" || ! -d "$ANDROID_NDK_ROOT" ]] ; then
- export ANDROID_NDK_ROOT="${CHROME_SRC}/third_party/android_tools/ndk/"
- fi
- if [[ ! -d "${ANDROID_NDK_ROOT}" ]] ; then
- echo "Can not find Android NDK root ${ANDROID_NDK_ROOT}." >& 2
- return 1
- fi
-
- # We export "ANDROID_SDK_ROOT" for building Java source with the SDK.
- export ANDROID_SDK_ROOT=${ANDROID_BUILD_TOP}/prebuilts/sdk/\
-${ANDROID_SDK_VERSION}
- # Needed by android antfiles when creating apks.
- export ANDROID_SDK_HOME=${ANDROID_SDK_ROOT}
-
- # Unset ANDROID_TOOLCHAIN, so it could be set to checked-in 64-bit toolchain.
- # in common_vars_defines
- unset ANDROID_TOOLCHAIN
-
- common_vars_defines
-
- DEFINES+=" sdk_build=0"
- DEFINES+=" android_product_out=${ANDROID_PRODUCT_OUT}"
-
- if [[ -n "$CHROME_ANDROID_BUILD_WEBVIEW" ]]; then
- webview_build_init
- return
- fi
-
- # The non-SDK build currently requires the SDK path to build the framework
- # Java aidl files. TODO(steveblock): Investigate avoiding this requirement.
- DEFINES+=" android_sdk=${ANDROID_SDK_ROOT}"
- DEFINES+=" android_sdk_root=${ANDROID_SDK_ROOT}"
- DEFINES+=" android_sdk_tools=${ANDROID_SDK_ROOT}/../tools/linux"
- DEFINES+=" android_sdk_version=${ANDROID_SDK_VERSION}"
- DEFINES+=" android_toolchain=${ANDROID_TOOLCHAIN}"
-
- common_gyp_vars
-}
-
-################################################################################
# To build WebView, we use the Android build system and build inside an Android
# source tree. This method is called from non_sdk_build_init() and adds to the
# settings specified there.
« no previous file with comments | « build/android/envsetup.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698