Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: build/android/envsetup.sh

Issue 11137023: Remove redundant command line option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more removal Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/envsetup_functions.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/envsetup.sh
diff --git a/build/android/envsetup.sh b/build/android/envsetup.sh
index f94ca65b7b2aff0cec095f86ac27d00ac43a62fb..fa7c7391741dcc537e1ef9196e21709482a537ba 100755
--- a/build/android/envsetup.sh
+++ b/build/android/envsetup.sh
@@ -6,26 +6,17 @@
# Sets up environment for building Chromium on Android. It can either be
# compiled with the Android tree or using the Android SDK/NDK. To build with
-# NDK/SDK: ". build/android/envsetup.sh --sdk". Environment variable
+# NDK/SDK: ". build/android/envsetup.sh". Environment variable
# ANDROID_SDK_BUILD=1 will then be defined and used in the rest of the setup to
# specifiy build type.
# When building WebView as part of Android we can't use the SDK. Other builds
# default to using the SDK.
-# NOTE(yfriedman): This looks unnecessary but downstream the default value
-# should be 0 until all builds switch to SDK/NDK.
if [[ "${CHROME_ANDROID_BUILD_WEBVIEW}" -eq 1 ]]; then
export ANDROID_SDK_BUILD=0
else
export ANDROID_SDK_BUILD=1
fi
-# Loop over args in case we add more arguments in the future.
-while [ "$1" != "" ]; do
- case $1 in
- -s | --sdk ) export ANDROID_SDK_BUILD=1 ; shift ;;
- * ) shift ; break ;;
- esac
-done
if [[ "${ANDROID_SDK_BUILD}" -eq 1 ]]; then
echo "Using SDK build"
@@ -79,12 +70,10 @@ elif [[ -z "$ANDROID_BUILD_TOP" || \
echo " . build/envsetup.sh"
echo " lunch"
echo "Then try this again."
- echo "Or did you mean NDK/SDK build. Run envsetup.sh with --sdk argument."
+ echo "Or did you mean NDK/SDK build. Run envsetup.sh without any arguments."
return 1
elif [[ -n "$CHROME_ANDROID_BUILD_WEBVIEW" ]]; then
webview_build_init
-else
- non_sdk_build_init
fi
# Workaround for valgrind build
« no previous file with comments | « no previous file | build/android/envsetup_functions.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698