Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1113543002: Optimizing variable use by reducing scope

Created:
5 years, 7 months ago by ashish1.a
Modified:
5 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Optimizing variable use by reducing scope Limiting the scope of variables in following files: 1) Source/core/loader/appcache/ApplicationCache.cpp 2) Source/core/loader/FrameLoader.cpp BUG=NONE

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCache.cpp View 3 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ashish1.a
Kindly review! Thanks!
5 years, 7 months ago (2015-04-28 11:52:51 UTC) #2
haraken
What's the advantage of this change?
5 years, 7 months ago (2015-04-28 11:56:02 UTC) #3
ashish1.a
5 years, 7 months ago (2015-04-29 04:19:50 UTC) #4
On 2015/04/28 11:56:02, haraken wrote:
> What's the advantage of this change?

Hello,
Below are some of the advantages of the above code changes:

1) Reducing the number of lines of code.
2) Limiting the scope of variable.

Regards,
Ashish

Powered by Google App Engine
This is Rietveld 408576698