Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11117024: Add second batch of controlled setting indicators (Closed)

Created:
8 years, 2 months ago by bartfab (slow)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Add second batch of controlled setting indicators This CL continues the addition of controlled setting indicators to the Chrome settings UI. BUG=104955 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162818

Patch Set 1 #

Patch Set 2 : Rebased and updated to ensure proper wrapping of new indicators. #

Patch Set 3 : Rebased and updated element nesting in line with CL 11141022. #

Patch Set 4 : Removed unnecessary <span> elements. #

Patch Set 5 : Fix accidental partial reverse of another CL. #

Patch Set 6 : Fix browser test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -10 lines) Patch
M chrome/browser/policy/policy_prefs_browsertest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 2 3 1 chunk +29 lines, -9 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bartfab (slow)
Hi James, can you please review the UI side? Hi Joao, can you please review ...
8 years, 2 months ago (2012-10-12 16:26:01 UTC) #1
James Hawkins
lgtm
8 years, 2 months ago (2012-10-12 22:22:11 UTC) #2
Joao da Silva
lgtm
8 years, 2 months ago (2012-10-15 07:42:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11117024/1
8 years, 2 months ago (2012-10-15 07:45:10 UTC) #4
bartfab (slow)
James, could you have another look? I want to make sure my changes in patch ...
8 years, 2 months ago (2012-10-15 11:25:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11117024/19001
8 years, 2 months ago (2012-10-18 18:48:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11117024/20004
8 years, 2 months ago (2012-10-18 20:10:46 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-18 22:46:45 UTC) #8 
Change committed as 162818

Powered by Google App Engine
This is Rietveld 408576698