src/arm/constants-arm.h - Issue 11116011: Simulate and disasm NOP on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/constants-arm.h

Issue 11116011: Simulate and disasm NOP on ARM (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Go back to MOV for NOP instead of the actual NOP instruction: it doesn't actually have a perf benef… Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/constants-arm.h

diff --git a/src/arm/constants-arm.h b/src/arm/constants-arm.h

index 5aadc3caeb413bcb6bdcebc874514546f23a867e..96bbf9b701677daeab1cc5d5322900887389aa2c 100644

--- a/src/arm/constants-arm.h

+++ b/src/arm/constants-arm.h

@@ -691,6 +691,9 @@ class Instruction {

&& (Bit(20) == 0)

&& ((Bit(7) == 0)); }

+ // Test for a nop instruction, which falls under type 1.

+ inline bool IsNopType1() const { return Bits(24, 0) == 0x0120F000; }

// Test for a stop instruction.

inline bool IsStop() const {

return (TypeValue() == 7) && (Bit(24) == 1) && (SvcValue() >= kStopCode);

« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/arm/disasm-arm.cc » ('j') | no next file with comments »