src/arm/disasm-arm.cc - Issue 11116011: Simulate and disasm NOP on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/disasm-arm.cc

Issue 11116011: Simulate and disasm NOP on ARM (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Go back to MOV for NOP instead of the actual NOP instruction: it doesn't actually have a perf benef… Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/disasm-arm.cc

diff --git a/src/arm/disasm-arm.cc b/src/arm/disasm-arm.cc

index 7c5f63edc903426db7af7f87adcaf06a2ade1aa7..3c94a46e62ae989baea43868cf43f976ec81c0a1 100644

--- a/src/arm/disasm-arm.cc

+++ b/src/arm/disasm-arm.cc

@@ -830,6 +830,8 @@ void Decoder::DecodeType01(Instruction* instr) {

} else {

Unknown(instr); // not used by V8

}

+ } else if ((type == 1) && instr->IsNopType1()) {

+ Format(instr, "nop'cond");

} else {

switch (instr->OpcodeField()) {

case AND: {

« no previous file with comments | « src/arm/constants-arm.h ('k') | src/arm/simulator-arm.cc » ('j') | no next file with comments »