Issue 11116011: Simulate and disasm NOP on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11116011: Simulate and disasm NOP on ARM (Closed)

Created:
8 years, 2 months ago by JF

Modified:
8 years, 2 months ago

Reviewers:
ulan

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Simulate and disasm NOP on ARM R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12737

Patch Set 1 #

Patch Set 2 : Fix formatting. #

Patch Set 3 : Go back to MOV for NOP instead of the actual NOP instruction: it doesn't actually have a perf benef… #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
M	src/arm/assembler-arm.cc	View	1 2	1 chunk	+7 lines, -3 lines	0 comments	Download
M	src/arm/constants-arm.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/arm/disasm-arm.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/arm/simulator-arm.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

PTAL. As discussed the generated code is the same, comment explains why we don't use ...

8 years, 2 months ago (2012-10-12 16:04:26 UTC) #1

ulan

8 years, 2 months ago (2012-10-15 15:39:32 UTC) #3

On 2012/10/15 15:23:36, ulan wrote:
> LGTM, I will land it for you.

I am changing the description to "Simulate and disasm NOP on ARM".

For the record the old description is

> Use ARMv7's encoding for NOP when available, instead of MOV x, x. 
> This doesn't seem to pay off, as the new NOP instruction has odd perf
semantics. 
> Simulate and disasm NOP.

Expand Messages | Collapse Messages