Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 11116002: [cc] Land preliminary empty headers for libcc renames (Closed)

Created:
8 years, 2 months ago by enne (OOO)
Modified:
8 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, Aaron Boodman, cc-bugs_chromium.org, mihaip-chromium-reviews_chromium.org, tfarina
Visibility:
Public.

Description

[cc] Land preliminary empty headers for libcc renames Landing empty headers first will prevent gyp conflicts later. BUG=155413 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161526

Patch Set 1 #

Total comments: 1

Patch Set 2 : Better metadata #

Patch Set 3 : Remove region.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -1 line) Patch
A cc/active_animation.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/animation_curve.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/animation_events.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/append_quads_data.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/bitmap_canvas_layer_texture_updater.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/bitmap_skpicture_canvas_layer_texture_updater.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/canvas_layer_texture_updater.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 2 2 chunks +134 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 2 chunks +19 lines, -1 line 0 comments Download
A cc/checkerboard_draw_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/completion_event.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/content_layer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/content_layer_client.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/damage_tracker.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/debug_border_draw_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/debug_rect_history.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/delay_based_time_source.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/delegated_renderer_layer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/delegated_renderer_layer_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/direct_renderer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/draw_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/font_atlas.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/frame_buffer_skpicture_canvas_layer_texture_updater.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/frame_rate_controller.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/frame_rate_counter.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/geometry_binding.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/gl_renderer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/graphics_context.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/heads_up_display_layer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/heads_up_display_layer_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/image_layer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/input_handler.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/io_surface_draw_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/io_surface_layer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/io_surface_layer_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/keyframed_animation_curve.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_animation_controller.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_iterator.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_painter.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_sorter.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_texture_sub_image.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_texture_updater.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_tiling_data.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_tree_host.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_tree_host_client.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_tree_host_common.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/layer_tree_host_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/math_util.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/occlusion_tracker.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/overdraw_metrics.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/page_scale_animation.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/platform_color.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/prioritized_texture.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/prioritized_texture_manager.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/priority_calculator.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/program_binding.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/proxy.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/quad_culler.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/quad_sink.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/rate_limiter.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/render_pass.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/render_pass_draw_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/render_pass_sink.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/render_surface.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/render_surface_filters.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/render_surface_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/renderer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/rendering_stats.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/resource_provider.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/scheduler.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/scheduler_state_machine.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/scoped_texture.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/scoped_thread_proxy.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/scrollbar_animation_controller.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/scrollbar_animation_controller_linear_fade.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/scrollbar_geometry_fixed_thumb.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/scrollbar_geometry_stub.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/scrollbar_layer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/scrollbar_layer_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/settings.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/shader.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/shared_quad_state.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/single_thread_proxy.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/skpicture_canvas_layer_texture_updater.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/software_renderer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/solid_color_draw_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/solid_color_layer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/solid_color_layer_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stream_video_draw_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/extensions_3d.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/extensions_3d_chromium.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/float_point.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/float_point_3d.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/float_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/float_rect.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/float_size.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/graphics_context_3d.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/graphics_types_3d.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/int_point.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/int_rect.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/int_size.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/not_implemented.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/skia_utils.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/tiling_data.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/trace_event.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/stubs/unit_bezier.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/animation_test_common.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/compositor_fake_web_graphics_context_3d.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/fake_graphics_context.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/fake_layer_tree_host_client.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/fake_web_compositor_output_surface.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/fake_web_compositor_software_output_device.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/fake_web_graphics_context_3d.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/fake_web_scrollbar_theme_geometry.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/geometry_test_utils.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/layer_test_common.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/layer_tree_test_common.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/mock_quad_culler.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/occlusion_tracker_test_common.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/render_pass_test_common.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/scheduler_test_common.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/test_common.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/tiled_layer_test_common.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/test/web_compositor_initializer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/texture.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/texture_copier.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/texture_draw_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/texture_layer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/texture_layer_client.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/texture_layer_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/texture_update_controller.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/texture_update_queue.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/texture_uploader.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/thread.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/thread_proxy.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/thread_task.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/threaded_test.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/throttled_texture_uploader.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/tile_draw_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/tiled_layer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/tiled_layer_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/time_source.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/timer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/timing_function.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/tree_synchronizer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/unthrottled_texture_uploader.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/video_layer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/video_layer_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A cc/yuv_video_draw_quad.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
enne (OOO)
8 years, 2 months ago (2012-10-11 23:59:34 UTC) #1
jamesr
lgtm but the diff itself has very weird metadata. Maybe you could try again with ...
8 years, 2 months ago (2012-10-12 00:02:43 UTC) #2
tfarina
http://codereview.chromium.org/11116002/diff/1/cc/yuv_video_draw_quad.h File cc/yuv_video_draw_quad.h (right): http://codereview.chromium.org/11116002/diff/1/cc/yuv_video_draw_quad.h#newcode1 cc/yuv_video_draw_quad.h:1: // Copyright 2012 The Chromium Authors. All rights reserved. ...
8 years, 2 months ago (2012-10-12 00:08:48 UTC) #3
jamesr
On 2012/10/12 00:08:48, tfarina wrote: > http://codereview.chromium.org/11116002/diff/1/cc/yuv_video_draw_quad.h > File cc/yuv_video_draw_quad.h (right): > > http://codereview.chromium.org/11116002/diff/1/cc/yuv_video_draw_quad.h#newcode1 > ...
8 years, 2 months ago (2012-10-12 00:12:46 UTC) #4
tfarina
On Thu, Oct 11, 2012 at 9:12 PM, <jamesr@chromium.org> wrote: > On 2012/10/12 00:08:48, tfarina ...
8 years, 2 months ago (2012-10-12 00:15:16 UTC) #5
enne (OOO)
On 2012/10/12 00:08:48, tfarina wrote: > http://codereview.chromium.org/11116002/diff/1/cc/yuv_video_draw_quad.h > File cc/yuv_video_draw_quad.h (right): > > http://codereview.chromium.org/11116002/diff/1/cc/yuv_video_draw_quad.h#newcode1 > ...
8 years, 2 months ago (2012-10-12 00:16:31 UTC) #6
tfarina
On Thu, Oct 11, 2012 at 9:16 PM, <enne@chromium.org> wrote: > http://codereview.chromium.org/11116002/diff/1/cc/yuv_video_draw_quad.h#newcode1 >> >> cc/yuv_video_draw_quad.h:1: ...
8 years, 2 months ago (2012-10-12 00:18:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11116002/5001
8 years, 2 months ago (2012-10-12 00:19:09 UTC) #8
commit-bot: I haz the power
Retried try job too often for step(s) compile
8 years, 2 months ago (2012-10-12 00:41:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11116002/7154
8 years, 2 months ago (2012-10-12 04:43:58 UTC) #10
commit-bot: I haz the power
8 years, 2 months ago (2012-10-12 07:20:04 UTC) #11
Change committed as 161526

Powered by Google App Engine
This is Rietveld 408576698