<browser>: Always read <browser>.src attribute from <object>.src.

content/renderer/browser_plugin/browser_plugin.cc

Index: content/renderer/browser_plugin/browser_plugin.cc
diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc
index adde725e61b83c614b638541935b9a737c56661b..4fe2d0686fe4e63d7e0432560d44d34f425d279a 100644
--- a/content/renderer/browser_plugin/browser_plugin.cc
+++ b/content/renderer/browser_plugin/browser_plugin.cc
@@ -136,7 +136,10 @@ void BrowserPlugin::SetSrcAttribute(const std::string& src) {
     // cannot be changed, so this value is used for enforcing this.
     navigate_src_sent_ = true;
   }
-  src_ = src;
+  if (!src.empty()) {
+    src_ = src;
+    return;

[Fady Samuel, 2012/10/12 20:03:36]

That seems wrong? If the src is not empty, we should navigate, here, you're
updating the member variable but not navigating?

[lazyboy, 2012/10/12 20:41:14]

I did the wrong change on that pass :S
Now moved the empty check at the very beginning, sanity check with resizes seems
ok and all browsertests pass.

+  }
   guest_crashed_ = false;
 }