<browser>: Always read <browser>.src attribute from <object>.src.

content/renderer/browser_plugin/browser_plugin.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin.h"
 
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #if defined (OS_WIN)
 #include "base/sys_info.h"
@@ skipping 118 matching lines @@
     // Record that we sent a NavigateGuest message to embedder. Once we send
     // such a message, subsequent SetSrcAttribute() calls must always send
     // NavigateGuest messages to the embedder (even if |src| is empty), so
     // resize works correctly for all cases (e.g. The embedder can reset the
     // guest's |src| to empty value, resize and then set the |src| to a
     // non-empty value).
     // Additionally, once this instance has navigated, the storage partition
     // cannot be changed, so this value is used for enforcing this.
     navigate_src_sent_ = true;
   }
-  src_ = src;
+  if (!src.empty()) {
+    src_ = src;
+    return;

[Fady Samuel, 2012/10/12 20:03:36]

That seems wrong? If the src is not empty, we should navigate, here, you're
updating the member variable but not navigating?

[lazyboy, 2012/10/12 20:41:14]

I did the wrong change on that pass :S
Now moved the empty check at the very beginning, sanity check with resizes seems
ok and all browsertests pass.

+  }
   guest_crashed_ = false;
 }
 
 std::string BrowserPlugin::GetPartitionAttribute() const {
   std::string value;
   if (persist_storage_)
     value.append(kPersistPrefix);
 
   value.append(storage_partition_id_);
   return value;
@@ skipping 607 matching lines @@
                                                  void* notify_data) {
 }
 
 void BrowserPlugin::didFailLoadingFrameRequest(
     const WebKit::WebURL& url,
     void* notify_data,
     const WebKit::WebURLError& error) {
 }
 
 }  // namespace content