<browser>: Always read <browser>.src attribute from <object>.src.

content/browser/browser_plugin/browser_plugin_embedder.cc

Index: content/browser/browser_plugin/browser_plugin_embedder.cc
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc
index 091c00c90b0bb8c400514743bb4431de4d7e1599..69ccb7fe2b88502e17ee7e940c4f785639bbeefc 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder.cc
+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc
@@ -122,17 +122,14 @@ void BrowserPluginEmbedder::NavigateGuest(
   WebContentsImpl* guest_web_contents =
       static_cast<WebContentsImpl*>(guest->GetWebContents());
 
-  // We ignore loading empty urls in web_contents.
+  // We do not load empty urls in web_contents.
   // If a guest sets empty src attribute after it has navigated to some
   // non-empty page, the action is considered no-op.

[Fady Samuel, 2012/10/12 20:45:05]

and should never be sent to the browser process.

[lazyboy, 2012/10/12 20:51:39]

Done.

-  // TODO(lazyboy): The js shim for browser-plugin might need to reflect empty
-  // src ignoring in the shadow DOM element: http://crbug.com/149001.
-  if (!src.empty()) {
-    guest_web_contents->GetController().LoadURL(url,
-                                                Referrer(),
-                                                PAGE_TRANSITION_AUTO_SUBFRAME,
-                                                std::string());
-  }
+  CHECK(!src.empty());
+  guest_web_contents->GetController().LoadURL(url,
+                                              Referrer(),
+                                              PAGE_TRANSITION_AUTO_SUBFRAME,
+                                              std::string());
 
   // Resize the guest if the resize parameter was set from the renderer.
   ResizeGuest(render_view_host, instance_id, resize_params);