<browser>: Always read <browser>.src attribute from <object>.src.

content/browser/browser_plugin/browser_plugin_embedder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_embedder.h"
 
 #include <set>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 104 matching lines @@
     RenderViewHost* render_view_host,
     int instance_id,
     const std::string& src,
     const BrowserPluginHostMsg_ResizeGuest_Params& resize_params) {
   BrowserPluginGuest* guest = GetGuestByInstanceID(instance_id);
   CHECK(guest);
   GURL url(src);
   WebContentsImpl* guest_web_contents =
       static_cast<WebContentsImpl*>(guest->GetWebContents());
 
-  // We ignore loading empty urls in web_contents.
+  // We do not load empty urls in web_contents.
   // If a guest sets empty src attribute after it has navigated to some
   // non-empty page, the action is considered no-op.

[Fady Samuel, 2012/10/12 20:45:05]

and should never be sent to the browser process.

[lazyboy, 2012/10/12 20:51:39]

Done.

-  // TODO(lazyboy): The js shim for browser-plugin might need to reflect empty
-  // src ignoring in the shadow DOM element: http://crbug.com/149001.
-  if (!src.empty()) {
-    guest_web_contents->GetController().LoadURL(url,
-                                                Referrer(),
-                                                PAGE_TRANSITION_AUTO_SUBFRAME,
-                                                std::string());
-  }
+  CHECK(!src.empty());
+  guest_web_contents->GetController().LoadURL(url,
+                                              Referrer(),
+                                              PAGE_TRANSITION_AUTO_SUBFRAME,
+                                              std::string());
 
   // Resize the guest if the resize parameter was set from the renderer.
   ResizeGuest(render_view_host, instance_id, resize_params);
 }
 
 void BrowserPluginEmbedder::UpdateRectACK(int instance_id,
                                           int message_id,
                                           const gfx::Size& size) {
   BrowserPluginGuest* guest = GetGuestByInstanceID(instance_id);
   if (guest)
@@ skipping 158 matching lines @@
       bool visible = *Details<bool>(details).ptr();
       WebContentsVisibilityChanged(visible);
       break;
     }
     default:
       NOTREACHED() << "Unexpected notification type: " << type;
   }
 }
 
 }  // namespace content