Chromium Code Reviews
Help | Chromium Project | Sign in
(23)

Issue 11109003: MIPS: Consistently use named getters for Lithium operands on ARM. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by palfia
Modified:
2 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Consistently use named getters for Lithium operands on ARM. Port r12527 (24ed881a) BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+444 lines, -262 lines) Patch
M src/mips/lithium-codegen-mips.cc View 76 chunks +121 lines, -121 lines 0 comments Download
M src/mips/lithium-mips.h View 102 chunks +303 lines, -119 lines 0 comments Download
M src/mips/lithium-mips.cc View 5 chunks +20 lines, -22 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
palfia
2 years, 7 months ago (2012-10-11 22:49:55 UTC) #1
Sven Panne
LGTM (in a rubberstamp-ish way... ;-)
2 years, 7 months ago (2012-10-12 06:53:05 UTC) #2
Sven Panne
2 years, 7 months ago (2012-10-12 07:02:34 UTC) #3
There were 2 tiny compilation problems in debug mode which I fixed. Landing...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be