Chromium Code Reviews
Help | Chromium Project | Sign in
(605)

Issue 11106021: Enable v8 verify heap on ASAN builds. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by inferno
Modified:
1 year, 6 months ago
Reviewers:
nsylvain
CC:
chromium-reviews_chromium.org, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Fix release, debug repetition in filename for ASAN, TSAN builds

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Lint Patch
M masters/master.chromium.lkgr/master_lkgr_cfg.py View 1 2 1 chunk +3 lines, -2 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 9
inferno
Michael, does this look right for enabling the v8 heap checking ? If yes, then ...
1 year, 6 months ago #1
nsylvain
https://chromiumcodereview.appspot.com/11106021/diff/1/masters/master.chromium.lkgr/master_lkgr_cfg.py File masters/master.chromium.lkgr/master_lkgr_cfg.py (right): https://chromiumcodereview.appspot.com/11106021/diff/1/masters/master.chromium.lkgr/master_lkgr_cfg.py#newcode99 masters/master.chromium.lkgr/master_lkgr_cfg.py:99: 'gclient_env': {'GYP_DEFINES': 'asan=1 linux_use_tcmalloc=0 v8_enable_verify_heap=1 '}})) 80-char. the rest ...
1 year, 6 months ago #2
mvstanton
On 2012/10/12 18:44:38, inferno wrote: > Michael, does this look right for enabling the v8 ...
1 year, 6 months ago #3
inferno
On 2012/10/13 08:21:11, mvstanton wrote: > On 2012/10/12 18:44:38, inferno wrote: > > Michael, does ...
1 year, 6 months ago #4
I haz the power (commit-bot)
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
1 year, 6 months ago #5
Michael Starzinger
On 2012/10/12 18:44:38, inferno wrote: > Michael, does this look right for enabling the v8 ...
1 year, 6 months ago #6
nsylvain
lgtm
1 year, 6 months ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/inferno@chromium.org/11106021/7001
1 year, 6 months ago #8
I haz the power (commit-bot)
1 year, 6 months ago #9
Change committed as 161865
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434