Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(26)

Issue 11103036: Don't clear EnumLength but rather copy the enum cache. Added regression test for crashes from chrom… (Closed)

Created:
5 years, 1 month ago by Toon Verwaest
Modified:
5 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Don't clear EnumLength but rather copy the enum cache. Added regression test for crashes from chromecrash. Committed: https://code.google.com/p/v8/source/detail?r=12704

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rephrasing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M src/objects.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-convert-enum.js View 1 1 chunk +26 lines, -11 lines 0 comments Download
Trybot results:

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL.
5 years, 1 month ago (2012-10-11 14:39:37 UTC) #1
Jakob Kummerow
lgtm https://chromiumcodereview.appspot.com/11103036/diff/1/test/mjsunit/regress/regress-convert-enum.js File test/mjsunit/regress/regress-convert-enum.js (right): https://chromiumcodereview.appspot.com/11103036/diff/1/test/mjsunit/regress/regress-convert-enum.js#newcode30 test/mjsunit/regress/regress-convert-enum.js:30: // Hold descriptors in c nit: Comments should ...
5 years, 1 month ago (2012-10-11 15:14:59 UTC) #2
Toon Verwaest
5 years, 1 month ago (2012-10-11 15:30:39 UTC) #3
Rewrote comments.

Powered by Google App Engine
This is Rietveld efc10ee0f