Issue 11103036: Don't clear EnumLength but rather copy the enum cache. Added regression test for crashes from chrom…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11103036: Don't clear EnumLength but rather copy the enum cache. Added regression test for crashes from chrom… (Closed)

Created:
8 years, 2 months ago by Toon Verwaest

Modified:
8 years, 2 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't clear EnumLength but rather copy the enum cache. Added regression test for crashes from chromecrash. Committed: https://code.google.com/p/v8/source/detail?r=12704

Patch Set 2 : Rephrasing comments #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -13 lines)			Patch
	M	src/objects.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-convert-enum.js	View	1	1 chunk	+26 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://chromiumcodereview.appspot.com/11103036/diff/1/test/mjsunit/regress/regress-convert-enum.js File test/mjsunit/regress/regress-convert-enum.js (right): https://chromiumcodereview.appspot.com/11103036/diff/1/test/mjsunit/regress/regress-convert-enum.js#newcode30 test/mjsunit/regress/regress-convert-enum.js:30: // Hold descriptors in c nit: Comments should ...

8 years, 2 months ago (2012-10-11 15:14:59 UTC) #2

Rewrote comments.

Expand Messages | Collapse Messages

Issue 11103036: Don't clear EnumLength but rather copy the enum cache. Added regression test for crashes from chrom… (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rephrasing comments #

Messages