Chromium Code Reviews
Help | Chromium Project | Sign in
(833)

Issue 11103036: Don't clear EnumLength but rather copy the enum cache. Added regression test for crashes from chrom… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Toon Verwaest
Modified:
1 year, 6 months ago
Reviewers:
Jakob
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Don't clear EnumLength but rather copy the enum cache. Added regression test for crashes from chromecrash.

Committed: https://code.google.com/p/v8/source/detail?r=12704

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rephrasing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Lint Patch
M src/objects.cc View 2 chunks +3 lines, -2 lines 0 comments 0 errors Download
A + test/mjsunit/regress/regress-convert-enum.js View 1 1 chunk +26 lines, -11 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Toon Verwaest
PTAL.
1 year, 6 months ago #1
Jakob
lgtm https://chromiumcodereview.appspot.com/11103036/diff/1/test/mjsunit/regress/regress-convert-enum.js File test/mjsunit/regress/regress-convert-enum.js (right): https://chromiumcodereview.appspot.com/11103036/diff/1/test/mjsunit/regress/regress-convert-enum.js#newcode30 test/mjsunit/regress/regress-convert-enum.js:30: // Hold descriptors in c nit: Comments should ...
1 year, 6 months ago #2
Toon Verwaest
1 year, 6 months ago #3
Rewrote comments.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6