Issue 11099064: Remove descriptors pointer.

Issue 11099064: Remove descriptors pointer. (Closed)

Created:
8 years, 2 months ago by Toon Verwaest

Modified:
8 years, 2 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove descriptors pointer. Secondary changes: - don't transfer ownership back on CNLT - turned debugging checks back into ASSERT Committed: https://code.google.com/p/v8/source/detail?r=12699

Patch Set 2 : Addressed nits #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -163 lines)			Patch
M	src/arm/macro-assembler-arm.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/objects.h	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	src/objects.cc	View		11 chunks	+34 lines, -51 lines	0 comments	Download
M	src/objects-inl.h	View		7 chunks	+14 lines, -35 lines	0 comments	Download
M	src/objects-visiting-inl.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/profile-generator.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/transitions.h	View		5 chunks	+7 lines, -11 lines	0 comments	Download
M	src/transitions.cc	View		4 chunks	+14 lines, -22 lines	0 comments	Download
M	src/transitions-inl.h	View		1 chunk	+8 lines, -15 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. https://chromiumcodereview.appspot.com/11099064/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://chromiumcodereview.appspot.com/11099064/diff/1/src/arm/macro-assembler-arm.cc#newcode3742 src/arm/macro-assembler-arm.cc:3742: FieldMemOperand(temp, TransitionArray::kDescriptorsOffset)); nit: fits on one ...

8 years, 2 months ago (2012-10-11 11:56:25 UTC) #2

Toon Verwaest

8 years, 2 months ago (2012-10-11 12:00:51 UTC) #3

Addressed comments.

https://chromiumcodereview.appspot.com/11099064/diff/1/src/arm/macro-assemble...
File src/arm/macro-assembler-arm.cc (right):

https://chromiumcodereview.appspot.com/11099064/diff/1/src/arm/macro-assemble...
src/arm/macro-assembler-arm.cc:3742: FieldMemOperand(temp,
TransitionArray::kDescriptorsOffset));
On 2012/10/11 11:56:25, Jakob wrote:
> nit: fits on one line

Done.

https://chromiumcodereview.appspot.com/11099064/diff/1/src/x64/macro-assemble...
File src/x64/macro-assembler-x64.cc (right):

https://chromiumcodereview.appspot.com/11099064/diff/1/src/x64/macro-assemble...
src/x64/macro-assembler-x64.cc:2940: FieldOperand(temp,
TransitionArray::kDescriptorsOffset));
On 2012/10/11 11:56:25, Jakob wrote:
> nit: fits on one line

Done.

Expand Messages | Collapse Messages