Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 11099064: Remove descriptors pointer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed nits Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3709 matching lines...) Expand 10 before | Expand all | Expand 10 after
3720 Register scratch) { 3720 Register scratch) {
3721 Register temp = descriptors; 3721 Register temp = descriptors;
3722 ldr(temp, FieldMemOperand(map, Map::kTransitionsOrBackPointerOffset)); 3722 ldr(temp, FieldMemOperand(map, Map::kTransitionsOrBackPointerOffset));
3723 3723
3724 Label ok, fail, load_from_back_pointer; 3724 Label ok, fail, load_from_back_pointer;
3725 CheckMap(temp, 3725 CheckMap(temp,
3726 scratch, 3726 scratch,
3727 isolate()->factory()->fixed_array_map(), 3727 isolate()->factory()->fixed_array_map(),
3728 &fail, 3728 &fail,
3729 DONT_DO_SMI_CHECK); 3729 DONT_DO_SMI_CHECK);
3730 ldr(temp, FieldMemOperand(temp, TransitionArray::kDescriptorsPointerOffset)); 3730 ldr(descriptors, FieldMemOperand(temp, TransitionArray::kDescriptorsOffset));
3731 ldr(descriptors, FieldMemOperand(temp, JSGlobalPropertyCell::kValueOffset));
3732 jmp(&ok); 3731 jmp(&ok);
3733 3732
3734 bind(&fail); 3733 bind(&fail);
3735 CompareRoot(temp, Heap::kUndefinedValueRootIndex); 3734 CompareRoot(temp, Heap::kUndefinedValueRootIndex);
3736 b(ne, &load_from_back_pointer); 3735 b(ne, &load_from_back_pointer);
3737 mov(descriptors, Operand(FACTORY->empty_descriptor_array())); 3736 mov(descriptors, Operand(FACTORY->empty_descriptor_array()));
3738 jmp(&ok); 3737 jmp(&ok);
3739 3738
3740 bind(&load_from_back_pointer); 3739 bind(&load_from_back_pointer);
3741 ldr(temp, FieldMemOperand(temp, Map::kTransitionsOrBackPointerOffset)); 3740 ldr(temp, FieldMemOperand(temp, Map::kTransitionsOrBackPointerOffset));
3742 ldr(temp, FieldMemOperand(temp, TransitionArray::kDescriptorsPointerOffset)); 3741 ldr(descriptors, FieldMemOperand(temp, TransitionArray::kDescriptorsOffset));
3743 ldr(descriptors, FieldMemOperand(temp, JSGlobalPropertyCell::kValueOffset));
3744 3742
3745 bind(&ok); 3743 bind(&ok);
3746 } 3744 }
3747 3745
3748 3746
3749 void MacroAssembler::NumberOfOwnDescriptors(Register dst, Register map) { 3747 void MacroAssembler::NumberOfOwnDescriptors(Register dst, Register map) {
3750 ldr(dst, FieldMemOperand(map, Map::kBitField3Offset)); 3748 ldr(dst, FieldMemOperand(map, Map::kBitField3Offset));
3751 DecodeField<Map::NumberOfOwnDescriptorsBits>(dst); 3749 DecodeField<Map::NumberOfOwnDescriptorsBits>(dst);
3752 } 3750 }
3753 3751
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
3856 void CodePatcher::EmitCondition(Condition cond) { 3854 void CodePatcher::EmitCondition(Condition cond) {
3857 Instr instr = Assembler::instr_at(masm_.pc_); 3855 Instr instr = Assembler::instr_at(masm_.pc_);
3858 instr = (instr & ~kCondMask) | cond; 3856 instr = (instr & ~kCondMask) | cond;
3859 masm_.emit(instr); 3857 masm_.emit(instr);
3860 } 3858 }
3861 3859
3862 3860
3863 } } // namespace v8::internal 3861 } } // namespace v8::internal
3864 3862
3865 #endif // V8_TARGET_ARCH_ARM 3863 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698