Issue 11098043: Simplify some of the startup code for SubStringStub::Generate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11098043: Simplify some of the startup code for SubStringStub::Generate. (Closed)

Created:
8 years, 2 months ago by JF

Modified:
8 years, 1 month ago

Reviewers:
ulan, Toon Verwaest

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@master

Visibility:
Public.

Simplify some of the startup code for SubStringStub::Generate. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12887

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -18 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 2 3 4	1 chunk	+16 lines, -11 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 2	2 chunks	+9 lines, -6 lines	0 comments	Download
M	src/arm/simulator-arm.cc	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

This adds ROR simulation on ARM from issue 11033005 (still in review).

8 years, 2 months ago (2012-10-11 12:40:14 UTC) #1

I clarified the comments, please review to see if it makes sense :-)

8 years, 2 months ago (2012-10-12 15:41:23 UTC) #2

On 2012/10/12 15:41:23, JF wrote: > I clarified the comments, please review to see if ...

8 years, 2 months ago (2012-10-16 00:59:52 UTC) #3

ulan

On 2012/10/16 09:48:55, Toon Verwaest wrote: > lgtm I will land it after http://codereview.chromium.org/11033005/ because ...

8 years, 2 months ago (2012-10-17 09:47:27 UTC) #5

Landed in r12887.