Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Side by Side Diff: src/arm/simulator-arm.cc

Issue 11098043: Simplify some of the startup code for SubStringStub::Generate. (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: Clarify comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/macro-assembler-arm.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1408 matching lines...) Expand 10 before | Expand all | Expand 10 after
1419 uint32_t uresult = static_cast<uint32_t>(result); 1419 uint32_t uresult = static_cast<uint32_t>(result);
1420 uresult >>= (shift_amount - 1); 1420 uresult >>= (shift_amount - 1);
1421 *carry_out = (uresult & 1) == 1; 1421 *carry_out = (uresult & 1) == 1;
1422 uresult >>= 1; 1422 uresult >>= 1;
1423 result = static_cast<int32_t>(uresult); 1423 result = static_cast<int32_t>(uresult);
1424 } 1424 }
1425 break; 1425 break;
1426 } 1426 }
1427 1427
1428 case ROR: { 1428 case ROR: {
1429 UNIMPLEMENTED(); 1429 if (shift_amount == 0) {
1430 *carry_out = c_flag_;
1431 } else {
1432 uint32_t left = static_cast<uint32_t>(result) >> shift_amount;
1433 uint32_t right = static_cast<uint32_t>(result) << (32 - shift_amount);
1434 result = right | left;
1435 *carry_out = (static_cast<uint32_t>(result) >> 31) != 0;
1436 }
1430 break; 1437 break;
1431 } 1438 }
1432 1439
1433 default: { 1440 default: {
1434 UNREACHABLE(); 1441 UNREACHABLE();
1435 break; 1442 break;
1436 } 1443 }
1437 } 1444 }
1438 } else { 1445 } else {
1439 // by register 1446 // by register
(...skipping 1975 matching lines...) Expand 10 before | Expand all | Expand 10 after
3415 uintptr_t address = *stack_slot; 3422 uintptr_t address = *stack_slot;
3416 set_register(sp, current_sp + sizeof(uintptr_t)); 3423 set_register(sp, current_sp + sizeof(uintptr_t));
3417 return address; 3424 return address;
3418 } 3425 }
3419 3426
3420 } } // namespace v8::internal 3427 } } // namespace v8::internal
3421 3428
3422 #endif // USE_SIMULATOR 3429 #endif // USE_SIMULATOR
3423 3430
3424 #endif // V8_TARGET_ARCH_ARM 3431 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/macro-assembler-arm.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698