New action box button images and supporting code

chrome/browser/ui/views/location_bar/action_box_button_view.h

Index: chrome/browser/ui/views/location_bar/action_box_button_view.h
diff --git a/chrome/browser/ui/views/location_bar/action_box_button_view.h b/chrome/browser/ui/views/location_bar/action_box_button_view.h
index d20b8476c03ca8fbae2417aaef4b2072c9311ddb..f2d305b723f83ed0671c5686cbaa798fb80b2745 100644
--- a/chrome/browser/ui/views/location_bar/action_box_button_view.h
+++ b/chrome/browser/ui/views/location_bar/action_box_button_view.h
@@ -25,6 +25,14 @@ class ActionBoxButtonView : public views::MenuButton,
    return &controller_;
   }
 
+  void SetClickableHeight(int clickable_height) {

[Peter Kasting, 2012/10/12 20:57:30]

This is much worse than the code before.  The location bar should definitely not
know about concepts like this.

The old code was weird not because it had a bottom area at all but because for
some reason the bottom area was declared as 2 px instead of 1 but then you
manually added 1 back.  That math made no sense, but the abstraction was in the
right place.

But honestly I don't understand why we care so much about not making the top and
bottom pixel clickable.  The location bar (on Windows at least) already treats
clicks on the bottom border as clicks in the location bar, why shouldn't we just
skip all the hittesting stuff entirely?

[yefimt, 2012/10/12 23:27:34]

Done.

+    clickable_height_ = clickable_height;
+  }
+
+  // Thickness of the top transparent area on a button image that overlaps
+  // location bar border.
+  static const int kTopBorderOverlapThickness;
+
  private:
   // Overridden from views::CustomButton:
   virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
@@ -33,6 +41,10 @@ class ActionBoxButtonView : public views::MenuButton,
   virtual void OnMenuButtonClicked(View* source,
                                    const gfx::Point& point) OVERRIDE;
 
+  // Overridden from veiws::View:
+  virtual bool HasHitTestMask() const;
+  virtual void GetHitTestMask(gfx::Path* mask) const;
+
   // Overridden from ActionBoxButtonController::Delegate:
   virtual void ShowMenu(scoped_ptr<ActionBoxMenuModel> menu_model) OVERRIDE;
 
@@ -44,6 +56,9 @@ class ActionBoxButtonView : public views::MenuButton,
 
   scoped_ptr<ActionBoxMenu> menu_;
 
+  // Height of the user clickable area of the button.
+  int clickable_height_;
+
   DISALLOW_COPY_AND_ASSIGN(ActionBoxButtonView);
 };