New action box button images and supporting code

chrome/browser/ui/views/location_bar/action_box_button_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ACTION_BOX_BUTTON_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ACTION_BOX_BUTTON_VIEW_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/ui/toolbar/action_box_button_controller.h"
 #include "ui/views/controls/button/menu_button.h"
 #include "ui/views/controls/button/menu_button_listener.h"
 
 class ActionBoxMenu;
 class Browser;
 
 // ActionBoxButtonView displays a plus button with associated menu.
 class ActionBoxButtonView : public views::MenuButton,
                             public views::MenuButtonListener,
                             public ActionBoxButtonController::Delegate {
  public:
   ActionBoxButtonView(Browser* browser, const gfx::Point& menu_offset);
   virtual ~ActionBoxButtonView();
 
   ActionBoxButtonController* action_box_button_controller() {
    return &controller_;
   }
 
+  void SetClickableHeight(int clickable_height) {

[Peter Kasting, 2012/10/12 20:57:30]

This is much worse than the code before.  The location bar should definitely not
know about concepts like this.

The old code was weird not because it had a bottom area at all but because for
some reason the bottom area was declared as 2 px instead of 1 but then you
manually added 1 back.  That math made no sense, but the abstraction was in the
right place.

But honestly I don't understand why we care so much about not making the top and
bottom pixel clickable.  The location bar (on Windows at least) already treats
clicks on the bottom border as clicks in the location bar, why shouldn't we just
skip all the hittesting stuff entirely?

[yefimt, 2012/10/12 23:27:34]

Done.

+    clickable_height_ = clickable_height;
+  }
+
+  // Thickness of the top transparent area on a button image that overlaps
+  // location bar border.
+  static const int kTopBorderOverlapThickness;
+
  private:
   // Overridden from views::CustomButton:
   virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
 
   // Overridden from views::MenuButtonListener:
   virtual void OnMenuButtonClicked(View* source,
                                    const gfx::Point& point) OVERRIDE;
 
+  // Overridden from veiws::View:
+  virtual bool HasHitTestMask() const;
+  virtual void GetHitTestMask(gfx::Path* mask) const;
+
   // Overridden from ActionBoxButtonController::Delegate:
   virtual void ShowMenu(scoped_ptr<ActionBoxMenuModel> menu_model) OVERRIDE;
 
   Browser* browser_;
 
   gfx::Point menu_offset_;
 
   ActionBoxButtonController controller_;
 
   scoped_ptr<ActionBoxMenu> menu_;
 
+  // Height of the user clickable area of the button.
+  int clickable_height_;
+
   DISALLOW_COPY_AND_ASSIGN(ActionBoxButtonView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ACTION_BOX_BUTTON_VIEW_H_