Chromium Code Reviews
Help | Chromium Project | Sign in
(851)

Issue 11093026: Reapply descriptor array sharing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Toon Verwaest
Modified:
1 year, 6 months ago
Reviewers:
Jakob
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Reapply descriptor array sharing.

This reverts commit 12669

Committed: https://code.google.com/p/v8/source/detail?r=12683

Patch Set 1 #

Patch Set 2 : Fix version number #

Patch Set 3 : Fixed regression and added checks to find origin of bugs. #

Total comments: 1

Patch Set 4 : fix long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+846 lines, -308 lines) Lint Patch
M src/arm/full-codegen-arm.cc View 2 chunks +20 lines, -14 lines 0 comments 0 errors Download
M src/arm/macro-assembler-arm.h View 1 chunk +9 lines, -0 lines 0 comments 0 errors Download
M src/arm/macro-assembler-arm.cc View 1 chunk +19 lines, -2 lines 0 comments 0 errors Download
M src/bootstrapper.cc View 2 chunks +3 lines, -2 lines 0 comments 0 errors Download
M src/handles.h View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M src/handles.cc View 4 chunks +37 lines, -11 lines 0 comments 0 errors Download
M src/heap.h View 3 chunks +13 lines, -13 lines 0 comments 0 errors Download
M src/heap.cc View 3 chunks +6 lines, -3 lines 0 comments 0 errors Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +16 lines, -8 lines 0 comments 0 errors Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +5 lines, -4 lines 0 comments 0 errors Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +19 lines, -2 lines 0 comments 0 errors Download
M src/mark-compact.cc View 2 chunks +6 lines, -5 lines 0 comments 0 errors Download
M src/objects.h View 13 chunks +49 lines, -25 lines 0 comments ? errors Download
M src/objects.cc View 1 2 37 chunks +375 lines, -95 lines 0 comments ? errors Download
M src/objects-debug.cc View 2 chunks +5 lines, -3 lines 0 comments 0 errors Download
M src/objects-inl.h View 12 chunks +91 lines, -42 lines 0 comments 0 errors Download
M src/objects-printer.cc View 1 2 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/profile-generator.cc View 2 chunks +25 lines, -10 lines 0 comments 0 errors Download
M src/property.h View 2 chunks +2 lines, -1 line 0 comments 0 errors Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M src/string-stream.cc View 1 chunk +4 lines, -1 line 0 comments 0 errors Download
M src/transitions.h View 5 chunks +15 lines, -9 lines 0 comments 0 errors Download
M src/transitions.cc View 4 chunks +19 lines, -4 lines 0 comments 0 errors Download
M src/transitions-inl.h View 2 chunks +15 lines, -11 lines 0 comments 0 errors Download
M src/version.cc View 1 1 chunk +1 line, -1 line 0 comments 0 errors Download
M src/x64/full-codegen-x64.cc View 2 chunks +15 lines, -8 lines 0 comments 0 errors Download
M src/x64/macro-assembler-x64.h View 1 chunk +6 lines, -4 lines 0 comments 0 errors Download
M src/x64/macro-assembler-x64.cc View 1 chunk +19 lines, -2 lines 0 comments 0 errors Download
M test/cctest/test-heap-profiler.cc View 1 chunk +15 lines, -4 lines 0 comments 0 errors Download
A + test/mjsunit/regress/regress-cntl-descriptors-enum.js View 1 chunk +17 lines, -4 lines 0 comments ? errors Download
A + test/mjsunit/regress/regress-convert-transition.js View 1 2 3 1 chunk +11 lines, -10 lines 0 comments ? errors Download
A + test/mjsunit/regress/regress-crbug-148376.js View 1 chunk +6 lines, -8 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Toon Verwaest
1 year, 6 months ago #1
Jakob
LGTM https://chromiumcodereview.appspot.com/11093026/diff/4001/test/mjsunit/regress/regress-convert-transition.js File test/mjsunit/regress/regress-convert-transition.js (right): https://chromiumcodereview.appspot.com/11093026/diff/4001/test/mjsunit/regress/regress-convert-transition.js#newcode28 test/mjsunit/regress/regress-convert-transition.js:28: var input = '{ "a1":1, "a2":1, "a3":1, "a4":1, ...
1 year, 6 months ago #2
Toon Verwaest
1 year, 6 months ago #3
addressed nit
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6