Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 11093026: Reapply descriptor array sharing. (Closed) Base URL: https://v8.googlecode.com/svn/trunk
Patch Set: fix long line Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | test/mjsunit/regress/regress-cntl-descriptors-enum.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc
index 1004104dd91ec974446ac5a4fe39c27798c6b306..4f7421be83a37d0987e7f0e75bd66d392c5ce93b 100644
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -1670,13 +1670,24 @@ TEST(MapHasDescriptorsAndTransitions) {
const v8::HeapGraphNode* global_object =
GetProperty(global, v8::HeapGraphEdge::kProperty, "obj");
CHECK_NE(NULL, global_object);
+
const v8::HeapGraphNode* map =
GetProperty(global_object, v8::HeapGraphEdge::kInternal, "map");
CHECK_NE(NULL, map);
- const v8::HeapGraphNode* descriptors =
- GetProperty(map, v8::HeapGraphEdge::kInternal, "descriptors");
+ const v8::HeapGraphNode* own_descriptors = GetProperty(
+ map, v8::HeapGraphEdge::kInternal, "descriptors");
+ CHECK_EQ(NULL, own_descriptors);
+ const v8::HeapGraphNode* own_transitions = GetProperty(
+ map, v8::HeapGraphEdge::kInternal, "transitions");
+ CHECK_EQ(NULL, own_transitions);
+
+ const v8::HeapGraphNode* back_pointer_map =
+ GetProperty(map, v8::HeapGraphEdge::kInternal, "backpointer");
+ CHECK_NE(NULL, back_pointer_map);
+ const v8::HeapGraphNode* descriptors = GetProperty(
+ back_pointer_map, v8::HeapGraphEdge::kInternal, "descriptors");
CHECK_NE(NULL, descriptors);
- const v8::HeapGraphNode* transitions =
- GetProperty(map, v8::HeapGraphEdge::kInternal, "transitions");
+ const v8::HeapGraphNode* transitions = GetProperty(
+ back_pointer_map, v8::HeapGraphEdge::kInternal, "transitions");
CHECK_NE(NULL, transitions);
}
« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | test/mjsunit/regress/regress-cntl-descriptors-enum.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698