Issue 11092094: Make ContentViewCore usable from other packages.

Issue 11092094: Make ContentViewCore usable from other packages. (Closed)

Created:
8 years, 2 months ago by aruslan

Modified:
8 years, 2 months ago

Reviewers:
David Trainor- moved to gerrit, nilesh

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make ContentViewCore usable from other packages. ContentViewCore methods are unaccessible from other packages that need to hook it to the View containers of their choice. BUG=146570 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161505

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed now unnecessary TODO. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nilesh

LGTM with nit. https://codereview.chromium.org/11092094/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/11092094/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1280 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1280: // work or expose computeHorizontalScrollOffset()/computeVerticalScrollOffset as ...

8 years, 2 months ago (2012-10-12 01:15:54 UTC) #3

aruslan

Thanks, Nilesh! https://codereview.chromium.org/11092094/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/11092094/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1280 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1280: // work or expose computeHorizontalScrollOffset()/computeVerticalScrollOffset as public. ...

8 years, 2 months ago (2012-10-12 01:18:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/11092094/6001

8 years, 2 months ago (2012-10-12 01:21:44 UTC) #5

Change committed as 161505

Expand Messages | Collapse Messages