Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 11092094: Make ContentViewCore usable from other packages. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed now unnecessary TODO. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 12888bea446da5c3b9290941eee2bf1e96c0d4dd..4073fc4e19a55503d22a8cc5019d6188e30b877c 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -1275,9 +1275,7 @@ public class ContentViewCore implements MotionEventDelegate {
* @see View#computeHorizontalScrollExtent()
*/
@SuppressWarnings("javadoc")
- protected int computeHorizontalScrollExtent() {
- // TODO (dtrainor): Need to expose scroll events properly to public. Either make getScroll*
- // work or expose computeHorizontalScrollOffset()/computeVerticalScrollOffset as public.
+ public int computeHorizontalScrollExtent() {
return getWidth();
}
@@ -1327,7 +1325,7 @@ public class ContentViewCore implements MotionEventDelegate {
* @see View#awakenScrollBars(int, boolean)
*/
@SuppressWarnings("javadoc")
- protected boolean awakenScrollBars(int startDelay, boolean invalidate) {
+ public boolean awakenScrollBars(int startDelay, boolean invalidate) {
// For the default implementation of ContentView which draws the scrollBars on the native
// side, calling this function may get us into a bad state where we keep drawing the
// scrollBars, so disable it by always returning false.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698