[cc] Use base ptr types for cc's CSS animation classes

[cc] Use base ptr types for cc's CSS animation classes

Rerelanding https://codereview.chromium.org/11085029/

BUG=154451
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161488

[enne (OOO), 2012-10-11 01:05:17]

This failed here:
http://build.chromium.org/p/chromium.win/builders/Win%20Builder%202008%20%28d...

However, the CQ passed the Win trybot, which seems awfully mysterious.

[enne (OOO), 2012-10-11 01:06:47]

Er,
http://build.chromium.org/p/chromium.win/builders/Win%20Builder%202008%20%28d....

[jamesr, 2012-10-11 04:37:57]

lgtm

https://codereview.chromium.org/11091057/diff/2001/cc/CCKeyframedAnimationCur...
File cc/CCKeyframedAnimationCurve.cpp (right):

https://codereview.chromium.org/11091057/diff/2001/cc/CCKeyframedAnimationCur...
cc/CCKeyframedAnimationCurve.cpp:83: return CCFloatKeyframe::create(time(),
value(), timingFunction() ? cloneTimingFunction(timingFunction()) :
scoped_ptr<CCTimingFunction>().Pass());
I wonder if this is teh funky because it's a ternary - the rules for when a
temporary is created vs a reference vs who knows what else are really esoteric. 
If this still doesn't work I'd break this out into an if

[commit-bot: I haz the power, 2012-10-11 22:34:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/11091057/8001

[commit-bot: I haz the power, 2012-10-12 03:35:10]

Change committed as 161488

[falken, 2012-10-12 06:56:47]

Sorry to revert this as well.

http://build.chromium.org/p/chromium.win/builders/Win%20Builder%202008%20%28d...
529>.\test\CCAnimationTestCommon.cpp(25) : error C2248:
'scoped_ptr<C>::scoped_ptr' : cannot access private member declared in class
'scoped_ptr<C>'