Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 11091028: [cc] Remove all WTF #includes from CCLayerTreeHost (Closed)

Created:
8 years, 2 months ago by enne (OOO)
Modified:
8 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, tfarina
Visibility:
Public.

Description

[cc] Remove all WTF #includes from CCLayerTreeHost This transitively involved cleaning up RateLimiter and the types that CCProxy, CCPrioritizedTextureManager, and CCPrioritizedTexture are stored in. This is a relanding of https://chromiumcodereview.appspot.com/11035071. BUG=154451 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -126 lines) Patch
M cc/BitmapCanvasLayerTextureUpdater.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/BitmapCanvasLayerTextureUpdater.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/BitmapSkPictureCanvasLayerTextureUpdater.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/BitmapSkPictureCanvasLayerTextureUpdater.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCDelegatedRendererLayerImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCLayerTreeHost.h View 8 chunks +20 lines, -11 lines 0 comments Download
M cc/CCLayerTreeHost.cpp View 5 chunks +9 lines, -21 lines 0 comments Download
M cc/CCLayerTreeHostImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCLayerTreeHostImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCLayerTreeHostImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCLayerTreeHostTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/CCPrioritizedTexture.h View 2 chunks +5 lines, -4 lines 0 comments Download
M cc/CCPrioritizedTextureManager.h View 2 chunks +5 lines, -4 lines 0 comments Download
M cc/CCPrioritizedTextureTest.cpp View 13 chunks +29 lines, -29 lines 0 comments Download
M cc/CCSingleThreadProxy.h View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/CCSingleThreadProxy.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/CCTextureUpdateControllerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCThreadProxy.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/CCThreadProxy.cpp View 3 chunks +8 lines, -6 lines 0 comments Download
M cc/FrameBufferSkPictureCanvasLayerTextureUpdater.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/ImageLayerChromium.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/LayerTextureUpdater.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/LayerTextureUpdater.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/RateLimiter.h View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/RateLimiter.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M cc/TiledLayerChromium.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/TiledLayerChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/CCTiledLayerTestCommon.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/CCTiledLayerTestCommon.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
enne (OOO)
The original patch broke because WebKit landed the HashMap first/second -> key/value change and the ...
8 years, 2 months ago (2012-10-09 19:56:00 UTC) #1
tfarina
To make it easier to see what changed from the revert, i.e, what you did ...
8 years, 2 months ago (2012-10-09 19:58:07 UTC) #2
enne (OOO)
Ah, ok. I will do that next time, thanks.
8 years, 2 months ago (2012-10-09 20:07:22 UTC) #3
jamesr
lgtm
8 years, 2 months ago (2012-10-09 20:19:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11091028/1
8 years, 2 months ago (2012-10-09 22:56:52 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-10 01:29:02 UTC) #6
Change committed as 161002

Powered by Google App Engine
This is Rietveld 408576698