Issue 11091015: Better pub integration test error reporting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11091015: Better pub integration test error reporting. (Closed)

Created:
8 years, 2 months ago by Bob Nystrom

Modified:
8 years, 2 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Better pub integration test error reporting. Always includes the stderr when a test failures. Shows errors in stdout, stderr and the exit code all at once. Displays differences in expected output better. Committed: https://code.google.com/p/dart/source/detail?r=13390

Patch Set 1 #

Total comments: 4

Patch Set 2 : Reorganize a bit to get rid of some nesting. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -35 lines)			Patch
	M	utils/tests/pub/test_pub.dart	View	1	4 chunks	+71 lines, -35 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Yay for slightly less nasty output when pub tests fail.

8 years, 2 months ago (2012-10-08 23:43:18 UTC) #1

nweiz

lgtm https://codereview.chromium.org/11091015/diff/1/utils/tests/pub/test_pub.dart File utils/tests/pub/test_pub.dart (right): https://codereview.chromium.org/11091015/diff/1/utils/tests/pub/test_pub.dart#newcode637 utils/tests/pub/test_pub.dart:637: if (expected is RegExp) { I'd rather short-circuit ...

8 years, 2 months ago (2012-10-09 00:06:39 UTC) #2

Bob Nystrom

8 years, 2 months ago (2012-10-15 20:52:15 UTC) #3

https://chromiumcodereview.appspot.com/11091015/diff/1/utils/tests/pub/test_p...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/11091015/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:637: if (expected is RegExp) {
On 2012/10/09 00:06:39, nweiz wrote:
> I'd rather short-circuit than have so much nested code.

I reordered this to have a positive "is RegExp" test, which helped the editor's
inference.  I agree the nesting sucks, though. Re-organized into a separate
_validateOutputRegExp() function.

https://chromiumcodereview.appspot.com/11091015/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:641: failures.add('Expected $pipe to match
"${expected.pattern}" but got none.');
On 2012/10/09 00:06:39, nweiz wrote:
> Line length.

Done.

Expand Messages | Collapse Messages