Screen reader now reads the file manager selection.

Screen reader now reads the file manager selection.

Screen reader (Chrome Vox) on ChromeOS does not work correctly in File Manager. This patch makes the screen reader read file selection details, when the selection is changed.

BUG=151471
TEST=Enable Screen Reader, enter File Manager and click on several files to invoke Chrome Vox reading.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161151

[mtomasz, 2012-10-09 01:34:30]

I want to commit it again after a revert because of a silly mistake. Already
fixed. You can refer to the old issue http://codereview.chromium.org/10977032/.

PTAL.

[mtomasz, 2012-10-10 03:54:17]

On 2012/10/09 01:34:30, mtomasz wrote:
> I want to commit it again after a revert because of a silly mistake. Already
> fixed. You can refer to the old issue
http://codereview.chromium.org/10977032/.
> 
> PTAL.

Ping.

[Dmitry Zvorygin, 2012-10-10 12:31:27]

On 2012/10/10 03:54:17, mtomasz wrote:
> On 2012/10/09 01:34:30, mtomasz wrote:
> > I want to commit it again after a revert because of a silly mistake. Already
> > fixed. You can refer to the old issue
> http://codereview.chromium.org/10977032/.
> > 
> > PTAL.
> 
> Ping.

Sorry, I was on EngOffsite.

I don't like changes in changelist, which aren't actually required to fix the
issue. To fix your issue you had just to add and ID attribute to main.html, but
you decided to reorder lines in table.js and add comment in table_list.js.

Anyway, I can give you LGTM only on main.html, since I'm not owner of
shared/js/cr/ui/...

So either request additional reviewers, or truncate your CL.

[mtomasz, 2012-10-10 17:14:44]

On 2012/10/10 12:31:27, Dmitry Zvorygin wrote:
> On 2012/10/10 03:54:17, mtomasz wrote:
> > On 2012/10/09 01:34:30, mtomasz wrote:
> > > I want to commit it again after a revert because of a silly mistake.
Already
> > > fixed. You can refer to the old issue
> > http://codereview.chromium.org/10977032/.
> > > 
> > > PTAL.
> > 
> > Ping.
> 
> Sorry, I was on EngOffsite.
> 
> I don't like changes in changelist, which aren't actually required to fix the
> issue. To fix your issue you had just to add and ID attribute to main.html,
but
> you decided to reorder lines in table.js and add comment in table_list.js.
> 
> Anyway, I can give you LGTM only on main.html, since I'm not owner of
> shared/js/cr/ui/...
> 
> So either request additional reviewers, or truncate your CL.

@zvorygin:
Adding an id wouldn't work without reordering that lines in table.js. There was
a bug in it. Please read comments in the reverted CL.

[mtomasz, 2012-10-10 17:16:27]

On 2012/10/10 17:14:44, mtomasz wrote:
> On 2012/10/10 12:31:27, Dmitry Zvorygin wrote:
> > On 2012/10/10 03:54:17, mtomasz wrote:
> > > On 2012/10/09 01:34:30, mtomasz wrote:
> > > > I want to commit it again after a revert because of a silly mistake.
> Already
> > > > fixed. You can refer to the old issue
> > > http://codereview.chromium.org/10977032/.
> > > > 
> > > > PTAL.
> > > 
> > > Ping.
> > 
> > Sorry, I was on EngOffsite.
> > 
> > I don't like changes in changelist, which aren't actually required to fix
the
> > issue. To fix your issue you had just to add and ID attribute to main.html,
> but
> > you decided to reorder lines in table.js and add comment in table_list.js.
> > 
> > Anyway, I can give you LGTM only on main.html, since I'm not owner of
> > shared/js/cr/ui/...
> > 
> > So either request additional reviewers, or truncate your CL.
> 
> @zvorygin:
> Adding an id wouldn't work without reordering that lines in table.js. There
was
> a bug in it. Please read comments in the reverted CL.

@jhawkins: PTAL.

[James Hawkins, 2012-10-10 17:23:31]

lgtm

[commit-bot: I haz the power, 2012-10-10 17:27:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/11090015/1

[commit-bot: I haz the power, 2012-10-10 19:29:15]

Change committed as 161151