Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2759)

Unified Diff: chrome/browser/resources/shared/js/cr/ui/table/table_list.js

Issue 11090015: Screen reader now reads the file manager selection. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/shared/js/cr/ui/table.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/shared/js/cr/ui/table/table_list.js
diff --git a/chrome/browser/resources/shared/js/cr/ui/table/table_list.js b/chrome/browser/resources/shared/js/cr/ui/table/table_list.js
index a161e2943a3a2975e19a08e6a1b8dff0e0a4ec96..e9865982e2900324ccf58fcd166df4029d75a34a 100644
--- a/chrome/browser/resources/shared/js/cr/ui/table/table_list.js
+++ b/chrome/browser/resources/shared/js/cr/ui/table/table_list.js
@@ -71,9 +71,11 @@ cr.define('cr.ui.table', function() {
},
renderFunction_: function(dataItem, table) {
+ // `This` must not be accessed here, since it may be anything, especially
+ // not a pointer to this object.
+
var cm = table.columnModel;
var listItem = List.prototype.createItem.call(table.list, '');
-
listItem.className = 'table-row';
for (var i = 0; i < cm.size; i++) {
« no previous file with comments | « chrome/browser/resources/shared/js/cr/ui/table.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698