Issue 11088067: Clear source_id_{audio,video}_ after RemoveId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11088067: Clear source_id_{audio,video}_ after RemoveId. (Closed)

Created:
8 years, 2 months ago by strobe_

Modified:
8 years, 2 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org, mattward_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clear source_id_{audio,video}_ after RemoveId. After adding a source buffer and then immediately removing it, new source buffers containing the same content component couldn't be added to the same MediaSource object. Such a pattern could be used as an ad-hoc canPlayType() for Media Source. This fixes. BUG=155226 TEST=ChunkDemuxer.TestRemoveAndAddId Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161369

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -4 lines)			Patch
	M	media/filters/chunk_demuxer.cc	View		1 chunk	+10 lines, -4 lines	0 comments	Download
	M	media/filters/chunk_demuxer_unittest.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/strobe@google.com/11088067/1

8 years, 2 months ago (2012-10-11 15:36:33 UTC) #3

Change committed as 161369

Expand Messages | Collapse Messages