Chromium Code Reviews
Help | Chromium Project | Sign in
(180)

Issue 11088067: Clear source_id_{audio,video}_ after RemoveId. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by strobe_
Modified:
2 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mattward_google.com
Visibility:
Public.

Description

Clear source_id_{audio,video}_ after RemoveId. After adding a source buffer and then immediately removing it, new source buffers containing the same content component couldn't be added to the same MediaSource object. Such a pattern could be used as an ad-hoc canPlayType() for Media Source. This fixes. BUG=155226 TEST=ChunkDemuxer.TestRemoveAndAddId Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M media/filters/chunk_demuxer.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
strobe_
2 years, 9 months ago (2012-10-11 05:07:40 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM
2 years, 9 months ago (2012-10-11 15:20:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/strobe@google.com/11088067/1
2 years, 9 months ago (2012-10-11 15:36:33 UTC) #3
commit-bot: I haz the power
2 years, 9 months ago (2012-10-11 17:30:34 UTC) #4
Change committed as 161369
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5