Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(49)

Issue 11087016: Create font with DEFAULT_CHARSET instead of ANSI_CHARSET. (Closed)

Created:
7 years, 2 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Create font with DEFAULT_CHARSET instead of ANSI_CHARSET. Users with non ANSI locale likely need non ANSI charset. BUG=152893

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/gfx/platform_font_win.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 30 (0 generated)
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/11087016/diff/3001/ui/gfx/render_text_win.cc File ui/gfx/render_text_win.cc (right): https://codereview.chromium.org/11087016/diff/3001/ui/gfx/render_text_win.cc#newcode648 ui/gfx/render_text_win.cc:648: switch(hr) { This error happens on JA XP for ...
7 years, 2 months ago (2012-10-08 23:18:40 UTC) #1
Vitaly Buka (NO REVIEWS)
Hi Alexei, seems you are the author of both pieces of code. Maybe you know ...
7 years, 2 months ago (2012-10-08 23:20:02 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/11087016/diff/7001/ui/gfx/render_text_win.cc File ui/gfx/render_text_win.cc (right): https://codereview.chromium.org/11087016/diff/7001/ui/gfx/render_text_win.cc#newcode649 ui/gfx/render_text_win.cc:649: if (hr == USP_E_SCRIPT_NOT_IN_FONT || I don't know why, ...
7 years, 2 months ago (2012-10-08 23:32:51 UTC) #3
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/11087016/diff/9014/ui/gfx/platform_font_win.cc File ui/gfx/platform_font_win.cc (right): https://codereview.chromium.org/11087016/diff/9014/ui/gfx/platform_font_win.cc#newcode201 ui/gfx/platform_font_win.cc:201: int font_size) { This also fixes hang and makes ...
7 years, 2 months ago (2012-10-09 06:09:42 UTC) #4
Alexei Svitkine (slow)
Sorry, I'm on vacation. Please try a different reviewer, for e.g. msw
7 years, 2 months ago (2012-10-12 08:40:24 UTC) #5
Vitaly Buka (NO REVIEWS)
Hi Xiaomei and Mike, can you take a look at this CL? Alexei on vacation ...
7 years, 2 months ago (2012-10-12 17:48:51 UTC) #6
msw
Thanks for digging into these issues. http://codereview.chromium.org/11087016/diff/9014/ui/gfx/platform_font_win.cc File ui/gfx/platform_font_win.cc (right): http://codereview.chromium.org/11087016/diff/9014/ui/gfx/platform_font_win.cc#newcode202 ui/gfx/platform_font_win.cc:202: HFONT hf = ...
7 years, 2 months ago (2012-10-12 20:50:56 UTC) #7
Vitaly Buka (NO REVIEWS)
http://codereview.chromium.org/11087016/diff/9014/ui/gfx/platform_font_win.cc File ui/gfx/platform_font_win.cc (right): http://codereview.chromium.org/11087016/diff/9014/ui/gfx/platform_font_win.cc#newcode202 ui/gfx/platform_font_win.cc:202: HFONT hf = ::CreateFont(-font_size, 0, 0, 0, 0, 0, ...
7 years, 2 months ago (2012-10-12 21:11:32 UTC) #8
Vitaly Buka (NO REVIEWS)
http://codereview.chromium.org/11087016/diff/9014/ui/gfx/render_text_win.cc File ui/gfx/render_text_win.cc (right): http://codereview.chromium.org/11087016/diff/9014/ui/gfx/render_text_win.cc#newcode650 ui/gfx/render_text_win.cc:650: hr == __HRESULT_FROM_WIN32(ERROR_INVALID_WINDOW_HANDLE)) { >> http://crbug.com/141702 I never see ...
7 years, 2 months ago (2012-10-12 21:14:19 UTC) #9
msw
Thanks for splitting into codereview.chromium.org/11143002 The other parts of this CL are likely still quite ...
7 years, 2 months ago (2012-10-12 21:34:55 UTC) #10
Vitaly Buka (NO REVIEWS)
http://codereview.chromium.org/11087016/diff/15001/ui/gfx/platform_font_win.cc#newcode202 > ui/gfx/platform_font_win.cc:202: HFONT hf = ::CreateFont(-font_size, 0, 0, 0, 0, > 0, 0, 0, ...
7 years, 2 months ago (2012-10-12 22:54:02 UTC) #11
msw
Note: I'm not an expert here, just trying to cover bases, get tests. (1) The ...
7 years, 2 months ago (2012-10-12 23:37:53 UTC) #12
Vitaly Buka (NO REVIEWS)
Alexei, can you take a look? Is this in general acceptable approach to fix the ...
7 years, 1 month ago (2012-10-23 16:31:11 UTC) #13
Alexei Svitkine (slow)
Hi Vitaly, I may have missed some of the conversation behind this, so I have ...
7 years, 1 month ago (2012-10-23 16:40:04 UTC) #14
Vitaly Buka (NO REVIEWS)
On 2012/10/23 16:40:04, Alexei Svitkine wrote: > Hi Vitaly, > > I may have missed ...
7 years, 1 month ago (2012-10-23 17:05:27 UTC) #15
Alexei Svitkine (slow)
On Tue, Oct 23, 2012 at 1:05 PM, <vitalybuka@chromium.org> wrote: > On 2012/10/23 16:40:04, Alexei ...
7 years, 1 month ago (2012-10-23 17:14:36 UTC) #16
Vitaly Buka (NO REVIEWS)
Chrome + windows 7 or Chrome + Win XP Ja 1. Open http://www.nikkei.com/ 2. Ctrl+P ...
7 years, 1 month ago (2012-10-23 17:33:41 UTC) #17
Vitaly Buka (NO REVIEWS)
Regarding redesign. Maybe it's more convenient way is to print headers/footers with webkit and leave ...
7 years, 1 month ago (2012-10-23 17:37:22 UTC) #18
Alexei Svitkine (slow)
(Oops, we lost the cc's a few emails ago, re-adding them.) On Tue, Oct 23, ...
7 years, 1 month ago (2012-10-23 18:46:49 UTC) #19
Vitaly Buka (NO REVIEWS)
On Tue, Oct 23, 2012 at 11:46 AM, Alexei Svitkine <asvitkine@chromium.org>wrote: > (Oops, we lost ...
7 years, 1 month ago (2012-10-23 18:52:14 UTC) #20
Alexei Svitkine (slow)
On Tue, Oct 23, 2012 at 2:51 PM, Vitaly Buka <vitalybuka@chromium.org>wrote: > > > On ...
7 years, 1 month ago (2012-10-23 19:01:14 UTC) #21
Vitaly Buka (NO REVIEWS)
On Tue, Oct 23, 2012 at 12:00 PM, Alexei Svitkine <asvitkine@chromium.org>wrote: > > > On ...
7 years, 1 month ago (2012-10-23 20:38:46 UTC) #22
Vitaly Buka (NO REVIEWS)
Alexei, I just tried to change print_web_view_helper.cc to render header and footer just by creating ...
7 years, 1 month ago (2012-10-25 20:59:03 UTC) #23
Alexei Svitkine (slow)
On 2012/10/25 20:59:03, Vitaly Buka wrote: > Alexei, I just tried to change print_web_view_helper.cc to ...
7 years, 1 month ago (2012-10-25 21:04:12 UTC) #24
kmadhusu
I am sorry, I don't know much about these code. Adding vandebo@ to the reviewer ...
7 years, 1 month ago (2012-10-25 21:34:26 UTC) #25
Vitaly Buka (NO REVIEWS)
vandebo@ It's not review. Ignore that code. Just asking, if there is any objection to ...
7 years, 1 month ago (2012-10-25 21:41:58 UTC) #26
vandebo (ex-Chrome)
mm, Windows and fonts.. deferring to Arthur
7 years, 1 month ago (2012-10-25 21:42:46 UTC) #27
Vitaly Buka (NO REVIEWS)
In prev message skia -> gfx::RenderText On 2012/10/25 21:41:58, Vitaly Buka wrote: > vandebo@ It's ...
7 years, 1 month ago (2012-10-25 21:45:34 UTC) #28
vandebo (ex-Chrome)
On 2012/10/25 21:41:58, Vitaly Buka wrote: > vandebo@ It's not review. Ignore that code. > ...
7 years, 1 month ago (2012-10-25 21:48:53 UTC) #29
arthurhsu
7 years, 1 month ago (2012-10-25 21:49:58 UTC) #30
On 2012/10/25 21:48:53, vandebo wrote:
> On 2012/10/25 21:41:58, Vitaly Buka wrote:
> > vandebo@ It's not review. Ignore that code.
> > 
> > Just asking, if there is any objection to render header/footer in print
> preview
> > using Webkit instead of direct calls to Skia.
> 
> Ohh, I have no objection to that.  We had an intern that did the header/footer
> code and at some point we talked about using WebKit to draw the headers and
> footers and it wasn't clear how to do it.  If there's some advantage to
drawing
> the headers/footers in WebKit, that's fine.
> 
> Recalling a little more, WebKit doesn't normally draw in the margin area, so
> it's not clear to me if you can get WebKit to draw in the negative coordinate
> space; see also setDrawingArea(SkPDFDevice::kMargin_DrawingArea)
> 
> > 
> > On 2012/10/25 21:34:26, kmadhusu wrote:
> > > I am sorry, I don't know much about these code. Adding vandebo@ to the
> > reviewer
> > > list.

LGTM

Powered by Google App Engine
This is Rietveld 408576698