Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 11085055: Make the WebContentsUserData locator key private. (Closed)

Created:
8 years, 2 months ago by Avi (use Gerrit)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Make the WebContentsUserData locator key private. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161630

Patch Set 1 #

Patch Set 2 : rebase, catch more uses of the key #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chrome/browser/autofill/test_autofill_external_delegate_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobar_tab_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/autofill/autofill_external_delegate_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_external_delegate_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_user_data.h View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
8 years, 2 months ago (2012-10-10 21:22:02 UTC) #1
awong
LGTM
8 years, 2 months ago (2012-10-11 00:10:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11085055/5001
8 years, 2 months ago (2012-10-11 03:01:59 UTC) #3
commit-bot: I haz the power
Presubmit check for 11085055-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-11 03:02:07 UTC) #4
Avi (use Gerrit)
owner plz thx
8 years, 2 months ago (2012-10-11 03:05:17 UTC) #5
Ben Goodger (Google)
lgtm
8 years, 2 months ago (2012-10-12 16:27:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11085055/5001
8 years, 2 months ago (2012-10-12 16:28:32 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-12 18:56:58 UTC) #8
Change committed as 161630

Powered by Google App Engine
This is Rietveld 408576698