chrome/browser/infobars/infobar_tab_helper.cc - Issue 11085055: Make the WebContentsUserData locator key private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/infobars/infobar_tab_helper.cc

Issue 11085055: Make the WebContentsUserData locator key private. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, catch more uses of the key Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/infobars/infobar_tab_helper.cc

diff --git a/chrome/browser/infobars/infobar_tab_helper.cc b/chrome/browser/infobars/infobar_tab_helper.cc

index f0ce1acdc3cf9e046a79a890c1bf1d60a07d2eaf..bcbd72101735be60ac820d7b31af069beeffdb92 100644

--- a/chrome/browser/infobars/infobar_tab_helper.cc

+++ b/chrome/browser/infobars/infobar_tab_helper.cc

@@ -219,7 +219,7 @@ void InfoBarTabHelper::Observe(int type,

// ourselves lest other parts of the system attempt to add infobars or use

// us otherwise during the destruction.

DCHECK_EQ(web_contents(), content::Source<WebContents>(source).ptr());

- web_contents()->RemoveUserData(&kLocatorKey);

+ web_contents()->RemoveUserData(UserDataKey());

// That was the equivalent of "delete this". This object is now destroyed;

// returning from this function is the only safe thing to do.

return;