Issue 11079003: Clean up NaCl's SCons build.

Issue 11079003: Clean up NaCl's SCons build. (Closed)

Created:
8 years, 2 months ago by Nick Bray (chromium)

Modified:
8 years, 2 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Clean up NaCl's SCons build. The change involved deleting several dead *.scons files, eliminating a dead dependancy on a script that downloaded Chrome binaries, and unwinding a nonstandard use of Sconscript to include a file. BUG= http://code.google.com/p/chromium/issues/detail?id=154400 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160748

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -748 lines)			Patch
M	ppapi/native_client/chrome_main.scons	View		3 chunks	+14 lines, -38 lines	0 comments	Download
M	ppapi/native_client/ppapi_scons_files.py	View	1	3 chunks	+1 line, -8 lines	0 comments	Download
D	ppapi/native_client/src/shared/ppapi/build.scons	View		1 chunk	+0 lines, -40 lines	0 comments	Download
D	ppapi/native_client/src/shared/ppapi_proxy/build.scons	View		1 chunk	+0 lines, -96 lines	0 comments	Download
D	ppapi/native_client/src/shared/ppapi_proxy/nacl.scons	View		1 chunk	+0 lines, -125 lines	0 comments	Download
D	ppapi/native_client/src/trusted/plugin/build.scons	View		1 chunk	+0 lines, -202 lines	0 comments	Download
D	ppapi/native_client/tests/nacl.scons	View		1 chunk	+0 lines, -68 lines	0 comments	Download
D	ppapi/native_client/tests/ppapi_browser/ppb_file_system/build.scons	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	ppapi/native_client/tests/ppapi_geturl/build.scons	View	1	1 chunk	+0 lines, -28 lines	0 comments	Download
D	ppapi/native_client/tests/ppapi_messaging/build.scons	View		1 chunk	+0 lines, -60 lines	0 comments	Download
M	ppapi/native_client/tests/ppapi_test_lib/nacl.scons	View		1 chunk	+0 lines, -10 lines	0 comments	Download
D	ppapi/native_client/tests/ppapi_tests/build.scons	View		1 chunk	+0 lines, -45 lines	0 comments	Download

Total messages: 4 (0 generated)

Nick Bray (chromium)

This change depends on turning off the build of irt.nexe on the NaCl side, first. ...

8 years, 2 months ago (2012-10-05 22:37:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/11079003/3001

8 years, 2 months ago (2012-10-08 21:54:11 UTC) #3

Change committed as 160748