Chromium Code Reviews
Help | Chromium Project | Sign in
(21)

Issue 11072014: Reverting sharing of descriptor arrays: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Toon Verwaest
Modified:
1 year, 6 months ago
Reviewers:
Jakob
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Reverting sharing of descriptor arrays:

- Sharing of descriptor arrays.
- Ensure correct enumeration indices in the dict.
- Clear the EnumLength fields of maps that lose their enumeration cache.
- Directly set the value in the descriptors pointer to avoid checks.
- CNLT with descriptors but no valid enum fields has to clear the
EnumCache.
- Only count the descriptor array if it's owned by the map.
- Restore the descriptor array before returning allocation failure.

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=12669

Patch Set 1 #

Total comments: 1

Patch Set 2 : Bump version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -905 lines) Lint Patch
M src/arm/full-codegen-arm.cc View 2 chunks +14 lines, -20 lines 0 comments 0 errors Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -9 lines 0 comments 0 errors Download
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -19 lines 0 comments 0 errors Download
M src/bootstrapper.cc View 2 chunks +2 lines, -3 lines 0 comments 0 errors Download
M src/handles.h View 1 chunk +0 lines, -1 line 0 comments 0 errors Download
M src/handles.cc View 4 chunks +11 lines, -37 lines 0 comments 0 errors Download
M src/heap.h View 3 chunks +13 lines, -13 lines 0 comments 0 errors Download
M src/heap.cc View 3 chunks +3 lines, -6 lines 0 comments 0 errors Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +8 lines, -16 lines 0 comments 0 errors Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +4 lines, -5 lines 0 comments 0 errors Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +2 lines, -19 lines 0 comments 0 errors Download
M src/mark-compact.cc View 2 chunks +5 lines, -6 lines 0 comments 0 errors Download
M src/objects.h View 13 chunks +25 lines, -49 lines 0 comments 0 errors Download
M src/objects.cc View 37 chunks +95 lines, -388 lines 0 comments 0 errors Download
M src/objects-debug.cc View 2 chunks +3 lines, -5 lines 0 comments 0 errors Download
M src/objects-inl.h View 12 chunks +42 lines, -91 lines 0 comments 0 errors Download
M src/profile-generator.cc View 2 chunks +10 lines, -25 lines 0 comments 0 errors Download
M src/property.h View 2 chunks +1 line, -2 lines 0 comments 0 errors Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M src/string-stream.cc View 1 chunk +1 line, -4 lines 0 comments 0 errors Download
M src/transitions.h View 5 chunks +9 lines, -15 lines 0 comments 0 errors Download
M src/transitions.cc View 4 chunks +4 lines, -19 lines 0 comments 0 errors Download
M src/transitions-inl.h View 2 chunks +11 lines, -15 lines 0 comments 0 errors Download
M src/version.cc View 1 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/x64/full-codegen-x64.cc View 2 chunks +8 lines, -15 lines 0 comments ? errors Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -6 lines 0 comments 0 errors Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -19 lines 0 comments 0 errors Download
M test/cctest/test-heap-profiler.cc View 1 chunk +4 lines, -15 lines 0 comments 0 errors Download
D test/mjsunit/regress/regress-cntl-descriptors-enum.js View 1 chunk +0 lines, -46 lines 0 comments ? errors Download
D test/mjsunit/regress/regress-crbug-148376.js View 1 chunk +0 lines, -35 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Toon Verwaest
PTAL.
1 year, 6 months ago #1
Jakob
1 year, 6 months ago #2
LGTM (reviewed version.cc, rubber-stamped the rest)

https://chromiumcodereview.appspot.com/11072014/diff/1/src/version.cc
File src/version.cc (right):

https://chromiumcodereview.appspot.com/11072014/diff/1/src/version.cc#newcode38
src/version.cc:38: #define PATCH_LEVEL       1
3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6