Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: src/transitions.h

Issue 11072014: Reverting sharing of descriptor arrays: (Closed) Base URL: https://v8.googlecode.com/svn/trunk
Patch Set: Bump version Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/string-stream.cc ('k') | src/transitions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 inline PropertyDetails GetTargetDetails(int transition_number); 65 inline PropertyDetails GetTargetDetails(int transition_number);
66 66
67 inline Map* elements_transition(); 67 inline Map* elements_transition();
68 inline void set_elements_transition( 68 inline void set_elements_transition(
69 Map* target, 69 Map* target,
70 WriteBarrierMode mode = UPDATE_WRITE_BARRIER); 70 WriteBarrierMode mode = UPDATE_WRITE_BARRIER);
71 inline bool HasElementsTransition(); 71 inline bool HasElementsTransition();
72 inline void ClearElementsTransition(); 72 inline void ClearElementsTransition();
73 73
74 inline DescriptorArray* descriptors(); 74 inline DescriptorArray* descriptors();
75 inline void set_descriptors(DescriptorArray* descriptors); 75 inline void set_descriptors(DescriptorArray* descriptors,
76 inline JSGlobalPropertyCell* descriptors_pointer(); 76 WriteBarrierMode mode = UPDATE_WRITE_BARRIER);
77 inline void set_descriptors_pointer(JSGlobalPropertyCell* pointer); 77 inline Object** GetDescriptorsSlot();
78 78
79 inline Object* back_pointer_storage(); 79 inline Object* back_pointer_storage();
80 inline void set_back_pointer_storage( 80 inline void set_back_pointer_storage(
81 Object* back_pointer, 81 Object* back_pointer,
82 WriteBarrierMode mode = UPDATE_WRITE_BARRIER); 82 WriteBarrierMode mode = UPDATE_WRITE_BARRIER);
83 83
84 inline FixedArray* GetPrototypeTransitions(); 84 inline FixedArray* GetPrototypeTransitions();
85 inline void SetPrototypeTransitions( 85 inline void SetPrototypeTransitions(
86 FixedArray* prototype_transitions, 86 FixedArray* prototype_transitions,
87 WriteBarrierMode mode = UPDATE_WRITE_BARRIER); 87 WriteBarrierMode mode = UPDATE_WRITE_BARRIER);
88 inline Object** GetPrototypeTransitionsSlot(); 88 inline Object** GetPrototypeTransitionsSlot();
89 inline bool HasPrototypeTransitions(); 89 inline bool HasPrototypeTransitions();
90 inline HeapObject* UncheckedPrototypeTransitions(); 90 inline HeapObject* UncheckedPrototypeTransitions();
91 91
92 // Returns the number of transitions in the array. 92 // Returns the number of transitions in the array.
93 int number_of_transitions() { 93 int number_of_transitions() {
94 ASSERT(length() >= kFirstIndex); 94 ASSERT(length() >= kFirstIndex);
95 int len = length(); 95 int len = length();
96 return len <= kFirstIndex ? 0 : (len - kFirstIndex) / kTransitionSize; 96 return len <= kFirstIndex ? 0 : (len - kFirstIndex) / kTransitionSize;
97 } 97 }
98 98
99 inline int number_of_entries() { return number_of_transitions(); } 99 inline int number_of_entries() { return number_of_transitions(); }
100 100
101 // Allocate a new transition array with a single entry. 101 // Allocate a new transition array with a single entry.
102 static MUST_USE_RESULT MaybeObject* NewWith( 102 static MUST_USE_RESULT MaybeObject* NewWith(String* name, Map* target);
103 String* name,
104 Map* target,
105 JSGlobalPropertyCell* descriptor_pointer,
106 Object* back_pointer);
107 103
108 // Copy the transition array, inserting a new transition. 104 // Copy the transition array, inserting a new transition.
109 // TODO(verwaest): This should not cause an existing transition to be 105 // TODO(verwaest): This should not cause an existing transition to be
110 // overwritten. 106 // overwritten.
111 MUST_USE_RESULT MaybeObject* CopyInsert(String* name, Map* target); 107 MUST_USE_RESULT MaybeObject* CopyInsert(String* name, Map* target);
112 108
113 // Copy a single transition from the origin array. 109 // Copy a single transition from the origin array.
114 inline void NoIncrementalWriteBarrierCopyFrom(TransitionArray* origin, 110 inline void NoIncrementalWriteBarrierCopyFrom(TransitionArray* origin,
115 int origin_transition, 111 int origin_transition,
116 int target_transition); 112 int target_transition);
117 113
118 // Search a transition for a given property name. 114 // Search a transition for a given property name.
119 inline int Search(String* name); 115 inline int Search(String* name);
120 116
121 // Allocates a TransitionArray. 117 // Allocates a TransitionArray.
122 MUST_USE_RESULT static MaybeObject* Allocate( 118 MUST_USE_RESULT static MaybeObject* Allocate(int number_of_transitions);
123 int number_of_transitions,
124 JSGlobalPropertyCell* descriptors_cell);
125 119
126 // Casting. 120 // Casting.
127 static inline TransitionArray* cast(Object* obj); 121 static inline TransitionArray* cast(Object* obj);
128 122
129 // Constant for denoting key was not found. 123 // Constant for denoting key was not found.
130 static const int kNotFound = -1; 124 static const int kNotFound = -1;
131 125
132 static const int kDescriptorsPointerIndex = 0; 126 static const int kDescriptorsIndex = 0;
133 static const int kBackPointerStorageIndex = 1; 127 static const int kBackPointerStorageIndex = 1;
134 static const int kElementsTransitionIndex = 2; 128 static const int kElementsTransitionIndex = 2;
135 static const int kPrototypeTransitionsIndex = 3; 129 static const int kPrototypeTransitionsIndex = 3;
136 static const int kFirstIndex = 4; 130 static const int kFirstIndex = 4;
137 131
138 // Layout transition array header. 132 // Layout transition array header.
139 static const int kDescriptorsPointerOffset = FixedArray::kHeaderSize; 133 static const int kDescriptorsOffset = FixedArray::kHeaderSize;
140 static const int kBackPointerStorageOffset = kDescriptorsPointerOffset + 134 static const int kBackPointerStorageOffset = kDescriptorsOffset +
141 kPointerSize; 135 kPointerSize;
142 static const int kElementsTransitionOffset = kBackPointerStorageOffset + 136 static const int kElementsTransitionOffset = kBackPointerStorageOffset +
143 kPointerSize; 137 kPointerSize;
144 static const int kPrototypeTransitionsOffset = kElementsTransitionOffset + 138 static const int kPrototypeTransitionsOffset = kElementsTransitionOffset +
145 kPointerSize; 139 kPointerSize;
146 140
147 // Layout of map transition. 141 // Layout of map transition.
148 static const int kTransitionKey = 0; 142 static const int kTransitionKey = 0;
149 static const int kTransitionTarget = 1; 143 static const int kTransitionTarget = 1;
150 static const int kTransitionSize = 2; 144 static const int kTransitionSize = 2;
151 145
152 #ifdef OBJECT_PRINT 146 #ifdef OBJECT_PRINT
153 // Print all the transitions. 147 // Print all the transitions.
154 inline void PrintTransitions() { 148 inline void PrintTransitions() {
155 PrintTransitions(stdout); 149 PrintTransitions(stdout);
156 } 150 }
157 void PrintTransitions(FILE* out); 151 void PrintTransitions(FILE* out);
158 #endif 152 #endif
159 153
160 #ifdef DEBUG 154 #ifdef DEBUG
161 bool IsSortedNoDuplicates(int valid_entries = -1); 155 bool IsSortedNoDuplicates();
162 bool IsConsistentWithBackPointers(Map* current_map); 156 bool IsConsistentWithBackPointers(Map* current_map);
163 bool IsEqualTo(TransitionArray* other); 157 bool IsEqualTo(TransitionArray* other);
164 #endif 158 #endif
165 159
166 // The maximum number of transitions we want in a transition array (should 160 // The maximum number of transitions we want in a transition array (should
167 // fit in a page). 161 // fit in a page).
168 static const int kMaxNumberOfTransitions = 1024 + 512; 162 static const int kMaxNumberOfTransitions = 1024 + 512;
169 163
170 private: 164 private:
171 // Conversion from transition number to array indices. 165 // Conversion from transition number to array indices.
(...skipping 13 matching lines...) Expand all
185 String* key, 179 String* key,
186 Map* target); 180 Map* target);
187 181
188 DISALLOW_IMPLICIT_CONSTRUCTORS(TransitionArray); 182 DISALLOW_IMPLICIT_CONSTRUCTORS(TransitionArray);
189 }; 183 };
190 184
191 185
192 } } // namespace v8::internal 186 } } // namespace v8::internal
193 187
194 #endif // V8_TRANSITIONS_H_ 188 #endif // V8_TRANSITIONS_H_
OLDNEW
« no previous file with comments | « src/string-stream.cc ('k') | src/transitions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698