Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 11068023: official find_sdk verify (Closed)

Created:
8 years, 2 months ago by Mark Mentovai
Modified:
8 years, 2 months ago
Reviewers:
TVL
CC:
chromium-reviews, Nico
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

When doing an official build, don't bail out if Xcode doesn't know about the SDK to verify when an SDK path is set. The SDK path supersedes whatever find_sdk is supposed to find. Also: Reorganize the SDK and deployment target variables to be scoped more appropriately. Add a mac_sdk_min variable to set the main argument to find_sdk. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160536

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -38 lines) Patch
M build/common.gypi View 1 8 chunks +55 lines, -37 lines 0 comments Download
M build/mac/find_sdk.py View 2 chunks +4 lines, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
Mark Mentovai
8 years, 2 months ago (2012-10-05 18:55:30 UTC) #1
Mark Mentovai
Nico’s on vacation.
8 years, 2 months ago (2012-10-05 20:45:56 UTC) #2
TVL
lgtm http://codereview.chromium.org/11068023/diff/1003/build/mac/find_sdk.py File build/mac/find_sdk.py (right): http://codereview.chromium.org/11068023/diff/1003/build/mac/find_sdk.py#newcode33 build/mac/find_sdk.py:33: help="user-specified SDK path; bypasses verification") it skips the ...
8 years, 2 months ago (2012-10-05 21:18:35 UTC) #3
Mark Mentovai
I think that’s fine. The build will die very quickly in that case and it ...
8 years, 2 months ago (2012-10-05 21:20:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mark@chromium.org/11068023/1003
8 years, 2 months ago (2012-10-05 21:50:15 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-06 00:46:31 UTC) #6
Change committed as 160536

Powered by Google App Engine
This is Rietveld 408576698