Move ContentViewCore native ownership to WebContents

Move ContentViewCore native ownership to WebContents
    
This means the nest of native objects (once built up) have the same life-times,
and the mismatch is handled at the JNI boundary.

GC might cause WebContents to get deleted before ContentViewCore (if AwContents is finalized before the java ContentViewCore)


BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162052

[joth, 2012-10-13 17:53:30]

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
File content/browser/android/content_view_core_impl.cc (right):

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:88: // would own WebContents.
The effectively requires making the WebContents
=> That effectively implies

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:96: ContentViewCoreImpl*
content_view_core_;
// Not using scoped_ptr as ContentViewCoreImpl destructor is private.

[Jay Civelli, 2012-10-15 17:11:49]

lgtm

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
File content/browser/android/content_view_core_impl.cc (right):

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:81:
ContentViewUserData(ContentViewCoreImpl* content_view_core)
explicit

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:93: ContentViewCoreImpl* get()
{ return content_view_core_; }
const

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:97: };
DISALLOW_...

[Ted C, 2012-10-15 17:46:44]

lgtm

[aruslan, 2012-10-15 17:47:23]

LGTM from a non-committer.

[joth, 2012-10-15 20:11:35]

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
File content/browser/android/content_view_core_impl.cc (right):

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:81:
ContentViewUserData(ContentViewCoreImpl* content_view_core)
On 2012/10/15 17:11:49, Jay Civelli wrote:
> explicit

Done.

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:88: // would own WebContents.
The effectively requires making the WebContents
On 2012/10/13 17:53:30, joth wrote:
> => That effectively implies

Done.

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:93: ContentViewCoreImpl* get()
{ return content_view_core_; }
On 2012/10/15 17:11:49, Jay Civelli wrote:
> const

Done.

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:96: ContentViewCoreImpl*
content_view_core_;
On 2012/10/13 17:53:30, joth wrote:
> // Not using scoped_ptr as ContentViewCoreImpl destructor is private.

Done.

http://codereview.chromium.org/11067002/diff/4001/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:97: };
On 2012/10/15 17:11:49, Jay Civelli wrote:
> DISALLOW_...

Done.

[Jay Civelli, 2012-10-15 20:27:09]

lgtm

[commit-bot: I haz the power, 2012-10-15 22:19:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joth@chromium.org/11067002/8002

[commit-bot: I haz the power, 2012-10-16 02:49:42]

Change committed as 162052