Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 11067002: Move ContentViewCore native ownership to WebContents (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: jcivelli feedback Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index 5ba4a66143f8d5bde21e99ef656481b6b539bf3e..5a5515d2a6a4953de7dff20f63ccb9c3d8439d7c 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -35,6 +35,7 @@ class RenderWidgetHostViewAndroid;
class ContentViewCoreImpl : public ContentViewCore,
public NotificationObserver {
public:
+ static ContentViewCoreImpl* FromWebContents(WebContents* web_contents);
ContentViewCoreImpl(JNIEnv* env,
jobject obj,
bool hardware_accelerated,
@@ -42,7 +43,6 @@ class ContentViewCoreImpl : public ContentViewCore,
ui::WindowAndroid* window_android);
// ContentViewCore implementation.
- virtual void Destroy(JNIEnv* env, jobject obj) OVERRIDE;
virtual base::android::ScopedJavaLocalRef<jobject> GetJavaObject() OVERRIDE;
virtual WebContents* GetWebContents() const OVERRIDE;
virtual ui::WindowAndroid* GetWindowAndroid() OVERRIDE;
@@ -54,6 +54,8 @@ class ContentViewCoreImpl : public ContentViewCore,
// Methods called from Java via JNI
// --------------------------------------------------------------------------
+ void OnJavaContentViewCoreDestroyed(JNIEnv* env, jobject obj);
+
// Notifies the ContentViewCore that items were selected in the currently
// showing select popup.
void SelectPopupMenuItems(JNIEnv* env, jobject obj, jintArray indices);
@@ -210,23 +212,22 @@ class ContentViewCoreImpl : public ContentViewCore,
gfx::Rect GetBounds() const;
private:
+ class ContentViewUserData;
+ friend class ContentViewUserData;
+ virtual ~ContentViewCoreImpl();
+
// NotificationObserver implementation.
virtual void Observe(int type,
const NotificationSource& source,
const NotificationDetails& details) OVERRIDE;
// --------------------------------------------------------------------------
- // Private methods that call to Java via JNI
- // --------------------------------------------------------------------------
- virtual ~ContentViewCoreImpl();
-
- // --------------------------------------------------------------------------
// Other private methods and data
// --------------------------------------------------------------------------
void InitJNI(JNIEnv* env, jobject obj);
- void InitWebContents(content::WebContents* web_contents);
+ void InitWebContents();
RenderWidgetHostViewAndroid* GetRenderWidgetHostViewAndroid();
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698