Issue 11055007: Scavenge watched objects by scavenging their watchers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11055007: Scavenge watched objects by scavenging their watchers. (Closed)

Created:
8 years, 2 months ago by cshapiro

Modified:
8 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Scavenge watched objects by scavenging their watchers. BUG=http://code.google.com/p/dart/issues/detail?id=5546 Committed: https://code.google.com/p/dart/source/detail?r=13157

Patch Set 2 : address review comments #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -13 lines)			Patch
	M	runtime/tests/vm/vm.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
	M	runtime/vm/scavenger.cc	View	1	1 chunk	+19 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comment. I added a unit test with https://chromiumcodereview.appspot.com/11047007/ -Ivan https://chromiumcodereview.appspot.com/11055007/diff/1/runtime/vm/scavenger.cc File runtime/vm/scavenger.cc (right): ...

8 years, 2 months ago (2012-10-02 23:02:30 UTC) #2

cshapiro

8 years, 2 months ago (2012-10-03 01:39:42 UTC) #3

https://chromiumcodereview.appspot.com/11055007/diff/1/runtime/vm/scavenger.cc
File runtime/vm/scavenger.cc (right):

https://chromiumcodereview.appspot.com/11055007/diff/1/runtime/vm/scavenger.c...
runtime/vm/scavenger.cc:126: // Forward the object by scavenging its watchers.
On 2012/10/02 23:02:31, Ivan Posva wrote:
> Can you add a comment here that we delayed visiting the pointers when we
> initially encountered the weak property object? Essentially at this point we
> know that the key is reachable so we should visit the pointers in the weak
> property.

Done.

Expand Messages | Collapse Messages

Issue 11055007: Scavenge watched objects by scavenging their watchers. (Closed)

Description

Patch Set 1 #

Patch Set 2 : address review comments #

Messages