<browser> Make new implementation the default.

<browser> Make new implementation the default.
Old implementation will be togglable by a flag kEnableBrowserPluginOldImplementation.

There are two js shims to create shadow DOM for two implementations, since we need to handle src differently in new path.

This would also fix src attribute setting behavior in apps for the new path.

Pending
1. Write tests to verify set src attribute fix for apps in new implementation path.

BUG=153629, 142379
TESTED=BrowserTest tests pending. Checked with platform app: a. set src initially. b. set src later via js using element.src c. set src later via js using elem.setAttribute('src', ...)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160225

[lazyboy, 2012-10-03 21:39:15]

Fady can you review this?

[Fady Samuel, 2012-10-03 21:50:59]

LGTM. Please have mihaip@ review this as he wrote the original shim.

[lazyboy, 2012-10-03 22:24:32]

Mihai, can you review this CL? Thanks.

[Mihai Parparita -not on Chrome, 2012-10-03 22:44:00]

LGTM

https://chromiumcodereview.appspot.com/11052019/diff/3002/chrome/browser/abou...
File chrome/browser/about_flags.cc (right):

https://chromiumcodereview.appspot.com/11052019/diff/3002/chrome/browser/abou...
chrome/browser/about_flags.cc:911: "enable-browser-plugin-old-implementation",
This seems pretty obscure, so showing it in chrome://flags may not be necessary.
Or are you expecting to have to toggle it on ChromeOS?

https://chromiumcodereview.appspot.com/11052019/diff/3002/chrome/renderer/chr...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://chromiumcodereview.appspot.com/11052019/diff/3002/chrome/renderer/chr...
chrome/renderer/chrome_content_renderer_client.cc:314: // TODO(lazyboy):
Restrict new path to apps as well?
Please do.

[lazyboy, 2012-10-03 23:26:57]

John, can you review this for OWNERS? Thanks.

https://chromiumcodereview.appspot.com/11052019/diff/3002/chrome/browser/abou...
File chrome/browser/about_flags.cc (right):

https://chromiumcodereview.appspot.com/11052019/diff/3002/chrome/browser/abou...
chrome/browser/about_flags.cc:911: "enable-browser-plugin-old-implementation",
On 2012/10/03 22:44:00, Mihai Parparita wrote:
> This seems pretty obscure, so showing it in chrome://flags may not be
necessary.
> Or are you expecting to have to toggle it on ChromeOS?

Removed from chrome://flags.
We don't expect this to be togglable in ChromeOS at this point.

https://chromiumcodereview.appspot.com/11052019/diff/3002/chrome/renderer/chr...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://chromiumcodereview.appspot.com/11052019/diff/3002/chrome/renderer/chr...
chrome/renderer/chrome_content_renderer_client.cc:314: // TODO(lazyboy):
Restrict new path to apps as well?
On 2012/10/03 22:44:00, Mihai Parparita wrote:
> Please do.

Done.
Also the other TODO below should be covered by the TODO in render_view_impl.cc,
therefore removed.

I will be adding another command line flag that enables browser plugin on
regular pages as well so we can use that for development.

[jam, 2012-10-04 18:26:46]

lgtm

[commit-bot: I haz the power, 2012-10-04 18:32:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/11052019/1019

[commit-bot: I haz the power, 2012-10-04 21:01:57]

Change committed as 160225