Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: chrome/renderer/resources/extensions/browser_tag.js

Issue 11052019: <browser> Make new implementation the default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove flag from chrome://flags, add platform app check for both implementation. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/dispatcher.cc ('k') | chrome/renderer/resources/extensions/browser_tag_old.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/browser_tag.js
diff --git a/chrome/renderer/resources/extensions/browser_tag.js b/chrome/renderer/resources/extensions/browser_tag.js
index bd0b8bd11d8c9af628ae468b6bedce7dd8e8057f..362ebea154313565dfbf0977853de2ced78ef992 100644
--- a/chrome/renderer/resources/extensions/browser_tag.js
+++ b/chrome/renderer/resources/extensions/browser_tag.js
@@ -73,7 +73,11 @@ function BrowserTag(node) {
BrowserTag.prototype.handleMutation_ = function(mutation) {
switch (mutation.attributeName) {
case 'src':
- this.objectNode_.postMessage(this.node_.getAttribute('src'));
+ // We need to set .src directly on the shadow element so that
+ // BrowserPluginBindings catches this as src attribute mutation. The
+ // bindings would catch 'SetAttribute' method call with src as argument
+ // otherwise.
+ this.objectNode_.src = this.node_.getAttribute('src');
break;
default:
this.copyAttribute_(mutation.attributeName);
« no previous file with comments | « chrome/renderer/extensions/dispatcher.cc ('k') | chrome/renderer/resources/extensions/browser_tag_old.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698