Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11052015: Fix bug with login-prompt-visible not being sent in some rare cases. (Closed)

Created:
8 years, 2 months ago by Nikita (slow)
Modified:
8 years, 2 months ago
Reviewers:
xiyuan, zel
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Fix bug with login-prompt-visible not being sent in some rare cases. Add more logging, force login-prompt-visible when initialized WebUI is shown. BUG=chrome-os-partner:14421 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159996

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M chrome/browser/chromeos/login/webui_login_view.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 3 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/login/demo_user_login.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/display_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_account_picker.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_error_message.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nikita (slow)
8 years, 2 months ago (2012-10-03 17:30:45 UTC) #1
zel
lgtm
8 years, 2 months ago (2012-10-03 18:24:07 UTC) #2
zel
+xiyuan
8 years, 2 months ago (2012-10-03 18:24:54 UTC) #3
xiyuan
LGTM
8 years, 2 months ago (2012-10-03 18:31:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/11052015/5001
8 years, 2 months ago (2012-10-03 20:18:49 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-03 22:37:02 UTC) #6
Change committed as 159996

Powered by Google App Engine
This is Rietveld 408576698